1136881 - Explore ways of implementing/integrating Firefox Hello in thunderbird

Status: RESOLVED WONTFIX

(Thunderbird :: Instant Messaging, enhancement)

Description

[Florent Fayolle]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150222232811

Steps to reproduce:

Firefox Hello is now shipped in Firefox 35/36.

It would be worth to propose the same thing in Thunderbird, using for example the Chat.

Comment 1

[Florent Fayolle]

(Initially a request from Jonas35 on IRC)

At least, a similar feature (I guess that's not through a URL that a communication can be established). 

Florent

Comment 2

[Patrick Cloke [:clokep]]

I don't really know what this is asking for, can you be more specific? I don't think Firefox Hello is a chat network.

Comment 3

[Florent Fayolle]

Asked on IRC

Comment 4

[Magnus Melin [:mkmelin]]

It's using WebRTC. I guess what would be nice is some integration to start a conversation. For that you have to get a link to the other party, and thunderbird has a number of ways to send that.

Comment 5

[Thomas D. (:thomas8)]

I like this idea, should be explored. Might become a cool new feature.

Comment 6

[Philippe VIGNEAU]

What's new here 5 months after ?...

Comment 7

[Patrick Cloke [:clokep]]

(In reply to Philippe VIGNEAU from comment #6)
> What's new here 5 months after ?...

None of the chat people are interested in this, so I think the status is "patches welcome". It's very unclear how to integrate Hello or what the expected use-case would be -- I'm tempted to WONTFIX this without a more specific expected user experience.

Comment 8

[Philippe VIGNEAU]

I don't think what is asked is to integrate Hello within Thunderbird, only provide WebRTC API would be sufficient for trying to build a plugin...

Comment 9

[Patrick Cloke [:clokep]]

WebRTC APIs should already be available.

I'm unsure of what the original author had in mind. But I'm going to WONTFIX this, if you can further explain this (or if someone else feels parts of this has merit), please open a new bug with specific details of what you'd like to see implemented.

Comment 10

[aleth [:aleth]]

(In reply to Philippe VIGNEAU from comment #8)
> I don't think what is asked is to integrate Hello within Thunderbird, only
> provide WebRTC API would be sufficient for trying to build a plugin...

You may be interested in the work in progress in bug 1018060 that uses WebRTC.

Comment 11

[Philippe VIGNEAU]

if I do :

document.getElementById("tabmail").openTab("contentTab", {contentPage: "https://hello.firefox.com/0gJogItxtOQ"});

I get :

"Firefox Hello fonctionne uniquement avec les navigateurs prenant en charge WebRTC"

Comment 12

[Florian Quèze [:florian]]

(In reply to Philippe VIGNEAU from comment #11)
> if I do :
> 
> document.getElementById("tabmail").openTab("contentTab", {contentPage:
> "https://hello.firefox.com/0gJogItxtOQ"});

To easily reproduce from the Thunderbird error console, I used:
Components.utils.import("resource://gre/modules/Services.jsm");Services.wm.getMostRecentWindow("mail:3pane").document.getElementById("tabmail").openTab("contentTab", {contentPage:"https://hello.firefox.com/0gJogItxtOQ"});

> I get :
> 
> "Firefox Hello fonctionne uniquement avec les navigateurs prenant en charge
> WebRTC"

For easier searching through the source code, the English version of the message is:
Firefox Hello only works in browsers that support WebRTC

From a quick look at the code, I think this message is shown because for some reason the OpenTok SDK function checking system requirements at http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/content/shared/libs/sdk.js?rev=f4c1152a490a#20205 returns false for Thunderbird.

Mike, is this guess correct? Is there anything to do about it?

Comment 13

[Philippe VIGNEAU]

@Florian : merci
@Patrick Cloke : OK there is nothing stable available anywhere to build a plugin... :flower: :heart: may you integrate this functionality into Thunderbird in the manner you like it (maybe with an email as input parameter) ? :O)

Comment 14

[Patrick Cloke [:clokep]]

(In reply to Philippe VIGNEAU from comment #13)
> @Patrick Cloke : OK there is nothing stable available anywhere to build a
> plugin... 

I don't know what this means.

> :flower: :heart: may you integrate this functionality into
> Thunderbird in the manner you like it (maybe with an email as input
> parameter) ? :O)

I have no plans to incorporate Hello into Thunderbird, if someone really wanted it and figured out a reasonable way to do it, I'd review a patch.

Comment 15

[Mike de Boer [:mikedeboer]]

(In reply to Florian Quèze [:florian] [:flo] from comment #12)
> For easier searching through the source code, the English version of the
> message is:
> Firefox Hello only works in browsers that support WebRTC
> 
> From a quick look at the code, I think this message is shown because for
> some reason the OpenTok SDK function checking system requirements at
> http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/
> content/shared/libs/sdk.js?rev=f4c1152a490a#20205 returns false for
> Thunderbird.
> 
> Mike, is this guess correct? Is there anything to do about it?

Yes, this appears to be correct: there's a certain amount of user-agent sniffing done to determine if 'webrtc' is supported.
Other requirement include:
 - have `window.mozRTCPeerConnection` defined.
 - have `window.mozGetUserMedia` defined.

My recommendation: propose a patch that maps Thunderbird to 'Firefox' at http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/content/shared/libs/sdk.js?rev=f4c1152a490a#2756 to the TokBox folks.
You can ask me to contact TokBox directly (I cc'd the relevant Bugzilla accounts).

Comment 16

[Mike de Boer [:mikedeboer]]

(In reply to Mike de Boer [:mikedeboer] from comment #15)
>  - have `window.mozGetUserMedia` defined.

ugh, s/window/navigator/.