1137051 - Don't show about-urls in the URL bar

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Perhaps it should continue to show 'Search or enter address' as a placeholder.

Comment 2

[Brian Nicholson (:bnicholson)]

Re-noming since this came up as a fix for bug 1123509, and that's tracking+.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/476

This does a little strange dance of setting BrowserLocationView.url to nil if you set it to "about:home". I'm expecting that might be contentions :)

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8607940 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/476

No argument here, makes sense to me. Might want to consider moving the about:home -> nil check outside of BrowserLocationView since that's more of an app detail than the URL bar responsibility, but not a big deal.

I'd double check your early return, though, as mentioned in the PR. I'm not sure didSet is recursive.

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 8607940 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/476

I liked your idea about moving the about:home logic out of here enough that I just did it. Mind looking at a second commit?

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8607940 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/476

Nice, I think I like this better too.