Closed Bug 1137076 Opened 10 years ago Closed 10 years ago

[Music]Quickly tapping the FF button crash the music app

Categories

(Core :: Audio/Video, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla39
blocking-b2g 2.2+
Tracking Status
firefox39 --- fixed
b2g-v2.2 --- fixed
b2g-v2.2r --- fixed
b2g-master --- verified

People

(Reporter: ericcc, Assigned: karlt)

References

Details

(Keywords: crash, regression, Whiteboard: [caf-crash 536][caf priority: p1][CR 867887][b2g-crash])

Crash Data

Attachments

(6 files)

### STR 1. Have a couple of song in 319MB flame 2. Tapping FF quickly ### Actual Music crashes ### Version Build ID 20150225160227 Gaia Revision cc235a867161e0000ea55a4f009b3be19021f066 Gaia Date 2015-02-25 05:01:27 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/6608e0605dfc Gecko Version 39.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150225.192909 Firmware Date Wed Feb 25 19:29:21 EST 2015 Bootloader L1TC100118D0
QA Whiteboard: [COM=Gaia::Music]
QA Contact: pcheng
[Blocking Requested - why for this release]: Functional regression causing a crash. Window already requested.
blocking-b2g: --- → 3.0?
mozilla-inbound regression window: Last Working Environmental Variables: Device: Flame BuildID: 20150215193544 Gaia: f0b93e0668ef9565bd6f050b15b4f794d59feb65 Gecko: 0bd4e491041a Version: 38.0a1 (3.0 Master) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 First Broken Environmental Variables: Device: Flame BuildID: 20150215210257 Gaia: f0b93e0668ef9565bd6f050b15b4f794d59feb65 Gecko: 3b86c91f7b96 Version: 38.0a1 (3.0 Master) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Gaia is the same so it's a Gecko issue. Gecko pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0bd4e491041a&tochange=3b86c91f7b96 Possibly caused by patch for bug 1095251 or bug 1132328.
QA Whiteboard: [COM=Gaia::Music] → [COM=Gaia::Music][QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Karl, can you take a look at this please? This could have been caused by the work done on either bug 1095251 or 1132328.
QA Whiteboard: [COM=Gaia::Music][QAnalyst-Triage?] → [COM=Gaia::Music][QAnalyst-Triage+]
Flags: needinfo?(ktucker) → needinfo?(karlt)
Crash Signature: [@ mozilla::MediaOmxReader::NotifyDataArrived(char const*, unsigned int, long long) ]
Whiteboard: [b2g-crash]
Crash Signature: [@ mozilla::MediaOmxReader::NotifyDataArrived(char const*, unsigned int, long long) ] → [@ mozilla::MediaOmxReader::NotifyDataArrived(char const*, unsigned int, long long) ] [@ mozilla::MediaOmxReader::ProcessCachedData(long long, bool) ]
Assignee: nobody → karlt
Blocks: 1095251
Component: Gaia::Music → Video/Audio
Flags: needinfo?(karlt)
Product: Firefox OS → Core
Version: unspecified → Trunk
Noticed on my master too, last one on Flame. The problem happen too with the "previous" button just by tapping "previous" or "next" two or three times fast.
Attachment #8571086 - Flags: review?(edwin)
Attachment #8571083 - Flags: review?(globelinmoz) → review?(edwin)
Issue is verified fixed in 3.0 Actual Results: No crash when tapping FF quickly Device: Flame 3.0 (KK - Nightly - Full Flash - 319mem) Build ID: 20150304010324 Gaia: 3fc0ac309f5fb0c1fe82c12223b955a4efce27e6 Gecko: c5b90c003be8 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 39.0a1 (Master) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [COM=Gaia::Music][QAnalyst-Triage+] → [COM=Gaia::Music][QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
QA Whiteboard: [COM=Gaia::Music][QAnalyst-Triage?] → [COM=Gaia::Music][QAnalyst-Triage+]
Flags: needinfo?(pbylenga)
See Also: → 1181641
blocking-b2g: 2.5? → 2.2?
Blocks: 1181641
Comment on attachment 8633645 [details] [diff] [review] rollup patch for b2g v2.2 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): none User impact if declined: Crash could happen during playing mp3 audio Testing completed: locally and codeaurora tested. Risk to taking this patch (and alternatives if risky): low String or UUID changes made by this patch: none
Attachment #8633645 - Flags: approval-mozilla-b2g37?
See Also: 1181641
Hi Mahe,
blocking-b2g: 2.2? → 2.2+
Approved the patch based on QA pass. Please uplift the patch. Thanks
Comment on attachment 8571083 [details] [diff] [review] remove declaration of undefined OmxDecoder::ProcessCachedData() [Triage Comment]
Attachment #8571083 - Flags: approval-mozilla-b2g37+
Hi Ryan, We need this also for 2.2r. Thanks!
Flags: needinfo?(ryanvm)
Whiteboard: [b2g-crash] → [CR 867887][b2g-crash]
Whiteboard: [CR 867887][b2g-crash] → [caf priority: p1][CR 867887][b2g-crash]
Whiteboard: [caf priority: p1][CR 867887][b2g-crash] → [caf-crash 536][caf priority: p1][CR 867887][b2g-crash]
Flags: needinfo?(ryanvm)
Attachment #8633645 - Flags: approval-mozilla-b2g37?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: