1137076 - [Music]Quickly tapping the FF button crash the music app

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Eric Chang [:ericcc] [:echang]]

### STR
1. Have a couple of song in 319MB flame
2. Tapping FF quickly

### Actual
Music crashes

### Version
Build ID               20150225160227
Gaia Revision          cc235a867161e0000ea55a4f009b3be19021f066
Gaia Date              2015-02-25 05:01:27
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6608e0605dfc
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150225.192909
Firmware Date          Wed Feb 25 19:29:21 EST 2015
Bootloader             L1TC100118D0

Comment 1

[Eric Chang [:ericcc] [:echang]]

Video
https://www.youtube.com/watch?v=3Y63NXwDjp0

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Functional regression causing a crash.

Window already requested.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

mozilla-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20150215193544
Gaia: f0b93e0668ef9565bd6f050b15b4f794d59feb65
Gecko: 0bd4e491041a
Version: 38.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20150215210257
Gaia: f0b93e0668ef9565bd6f050b15b4f794d59feb65
Gecko: 3b86c91f7b96
Version: 38.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Gaia is the same so it's a Gecko issue.

Gecko pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0bd4e491041a&tochange=3b86c91f7b96

Possibly caused by patch for bug 1095251 or bug 1132328.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Karl, can you take a look at this please? This could have been caused by the work done on either bug 1095251 or 1132328.

Comment 5

[Karl Tomlinson (:karlt)]

Yes, I'll have a look.  Thanks for the regression range.

https://crash-stats.mozilla.com/report/index/f0cce0a7-c0c9-412c-a866-8538f2150224
https://crash-stats.mozilla.com/report/index/b13acc69-2d4d-45d9-8b0f-df14c2150223

Comment 6

[Clément Lefèvre]

Noticed on my master too, last one on Flame.
The problem happen too with the "previous" button just by tapping "previous" or "next" two or three times fast.

Comment 7

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2510d0a26e22

Comment 8

[Karl Tomlinson (:karlt)]

Attachment: remove declaration of undefined OmxDecoder::ProcessCachedData()

Left over from http://hg.mozilla.org/mozilla-central/rev/92a7c3a6a88a

Comment 9

[Karl Tomlinson (:karlt)]

Attachment: handle null mDecoder during Reader shutdown

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1095251#c10

Comment 10

[Karl Tomlinson (:karlt)]

Attachment: mark some methods as private

Comment 11

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dce3800f08d9
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9735dd934a2
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f48676c7188

Perhaps it might be possible to write a crash test changing the src on a media element with mp3.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dce3800f08d9
https://hg.mozilla.org/mozilla-central/rev/b9735dd934a2
https://hg.mozilla.org/mozilla-central/rev/1f48676c7188

Comment 13

[Joshua Mitchell (Inactive)]

Issue is verified fixed in 3.0 

Actual Results: No crash when tapping FF quickly 

Device: Flame 3.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150304010324
Gaia: 3fc0ac309f5fb0c1fe82c12223b955a4efce27e6
Gecko: c5b90c003be8
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: rollup patch for b2g v2.2

Comment 15

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8633645 [details] [diff] [review]
rollup patch for b2g v2.2

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: Crash could happen during playing mp3 audio
Testing completed: locally and codeaurora tested.
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 16

[Josh Cheng [:josh]]

Hi Mahe,

Comment 17

[Mahendra Potharaju [:mahe]]

Approved the patch based on QA pass. Please uplift the patch. Thanks

Comment 18

[Mahendra Potharaju [:mahe]]

Comment on attachment 8571083 [details] [diff] [review]
remove declaration of undefined OmxDecoder::ProcessCachedData()

[Triage Comment]

Comment 20

[Josh Cheng [:josh]]

Hi Ryan,
We need this also for 2.2r. Thanks!

Comment 21

[cafbot (PoC: ggrisco)]

Observed on: 

Device: msm8909
Gonk Version: AU_LINUX_GECKO_LF.BR.1.2.3.00.00.00.000.214
Moz BuildID: 20150606002503
Manifest: https://www.codeaurora.org/cgit/quic/lf/b2g/manifest/tree/caf_AU_LINUX_GECKO_LF.BR.1.2.3.00.00.00.000.214.xml?h=release
B2G Version: v2.2
Gecko Version: 37.0
Gaia:  http://git.mozilla.org/?p=releases/gaia.git;a=commit;h=8fc797527a3eca7665bc1d1828848f2fb77ca99f
Gecko: http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=e0045f9c8b7e84fc52ba628141688c8ecb4b7a52
Patches: bug 1133147, bug 1181641

Comment 22

[cafbot (PoC: ggrisco)]

Attachment: EXTRA file attachment - AU_LINUX_GECKO_LF.BR.1.2.3.00.00.00.000.214

Comment 23

[cafbot (PoC: ggrisco)]

Attachment: decoded minidump - AU_LINUX_GECKO_LF.BR.1.2.3.00.00.00.000.214

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/13c447ed929e

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/13c447ed929e