Closed
Bug 1137094
Opened 10 years ago
Closed 10 years ago
Pseudolanguages break HTML in translations
Categories
(Firefox OS Graveyard :: Gaia::L10n, defect)
Firefox OS Graveyard
Gaia::L10n
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Unassigned)
References
Details
Attachments
(2 files)
We don't currently do anything to support HTML in translations which results in HTML element names and attributes ending up pseudolocalized as well.
Now that bug 1101632 is fixed and we can build pseudolocales on buildtime, I'm less concerned about the performance impact parsing HTML in translations might have.
It would be cool to use <template> for this but I'm afraid we'd run into the same problem we have in bug 994357.
Reporter | ||
Updated•10 years ago
|
Blocks: fxos-pseudolocales
Comment 1•10 years ago
|
||
Updated•10 years ago
|
Attachment #8601971 -
Flags: review?(stas)
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8601971 [details] [review]
[gaia] tedders1:bug-1137094-dont-pseudolocalize-html-tags > mozilla-b2g:master
This won't pseudo-localize localizable attributes like placeholders or titles but they aren't pseudolocalized right now either. Let;s land this; it's still a useful addition.
Since Ted is asleep now I'll submit a new PR in which I want to add a test.
Attachment #8601971 -
Flags: review?(stas) → review+
Comment 3•10 years ago
|
||
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8602049 [details] [review]
[gaia] stasm:1137094-dont-pseudo-html > mozilla-b2g:master
Let's land this.
Attachment #8602049 -
Flags: review+
Reporter | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/29914
The pull request could not be applied to the integration branch. Please try again after current integration is complete. You may need to rebase your branch against the target branch.
Reporter | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/29914
The pull request could not be applied to the integration branch. Please try again after current integration is complete. You may need to rebase your branch against the target branch.
Comment 7•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/9361a8dc0a84b5d4ed49bc5d0eb8635d008c41b3
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•10 years ago
|
||
L20n.js: https://github.com/l20n/l20n.js/commit/a8f67e8c906c5517b16e31bae1fb2894d7fad82c
Thanks Ted, this was easier than I thought :)
Reporter | ||
Comment 9•10 years ago
|
||
I realized that the autolander landed Ted's pull request which didn't have tests. Let's see if it can land mine now as a follow-up.
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 10•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6089234ace8b294a8feef064387604bae16254e3
You need to log in
before you can comment on or make changes to this bug.
Description
•