Closed
Bug 1137103
Opened 10 years ago
Closed 10 years ago
[bluetooth2] Simplify Bluetooth signal distribution function
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
2.2 S7 (6mar)
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: ben.tian, Assigned: ben.tian)
References
Details
(Whiteboard: [webbt-api])
Attachments
(1 file, 1 obsolete file)
|
21.99 KB,
patch
|
shawnjohnjr
:
review+
|
Details | Diff | Splinter Review |
Make |DistributeBluetoothSignal| accept arguments of name, path, and BluetoothValue to save repetitive code of BluetoothSignal creation.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → btian
Whiteboard: [webbt-api]
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Replace array with "true" as default BluetoothValue in |DistributeSignal|.
Attachment #8569717 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8570316 -
Flags: review?(shuang)
Comment on attachment 8570316 [details] [diff] [review]
Patch 1 (v2): Simplify Bluetooth signal distribution function
Review of attachment 8570316 [details] [diff] [review]:
-----------------------------------------------------------------
It looks good to me. Please push to try server for ICS BlueZ variant.
Attachment #8570316 -
Flags: review?(shuang) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S7 (6mar)
|
||
Comment 7•10 years ago
|
||
Can we get this uplifted to 2.2? This fixes bug 1150462 which is a 2.2 blocker.
You need to log in
before you can comment on or make changes to this bug.
Description
•