Closed Bug 1137103 Opened 9 years ago Closed 9 years ago

[bluetooth2] Simplify Bluetooth signal distribution function

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S7 (6mar)
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: ben.tian, Assigned: ben.tian)

References

Details

(Whiteboard: [webbt-api])

Attachments

(1 file, 1 obsolete file)

Patch 1 (v2): Simplify Bluetooth signal distribution function
21.99 KB, patch
shawnjohnjr
: review+
Details | Diff | Splinter Review 
Make |DistributeBluetoothSignal| accept arguments of name, path, and BluetoothValue to save repetitive code of BluetoothSignal creation.
Assignee: nobody → btian
Whiteboard: [webbt-api]
Depends on: 1137579
No longer depends on: 1137579
Replace array with "true" as default BluetoothValue in |DistributeSignal|.
Attachment #8569717 - Attachment is obsolete: true
No longer depends on: 1133655
Depends on: 1133655
Attachment #8570316 - Flags: review?(shuang)
Comment on attachment 8570316 [details] [diff] [review]
Patch 1 (v2): Simplify Bluetooth signal distribution function

Review of attachment 8570316 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good to me. Please push to try server for ICS BlueZ variant.
Attachment #8570316 - Flags: review?(shuang) → review+
https://hg.mozilla.org/mozilla-central/rev/2223dcf23382
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S7 (6mar)
Can we get this uplifted to 2.2? This fixes bug 1150462 which is a 2.2 blocker.
No longer depends on: 1150462
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: