1137141 - Contacts tab doesn't appear after login with FxA

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

I noticed that the Contacts tab doesn't show and hide anymore after logging in and out with FxA. Only after a browser restart does the tab appear.

This is critical and greatly reduces the usability of Loop/ Hello, because there's no way to access the direct calling feature this way.

Comment 1

[Mike de Boer [:mikedeboer]]

I introduced this bug in my patch for bug : here `shouldComponentUpdate` was introduced for the TabView component in panel.jsx. It checks for changed properties, but only for the components' changed state, not its properties. The `buttonsHidden` property is the one we need to account for, because it determines whether the Contacts tab buttons is shown.

This unfortunately affects release, Fx 36, and IMHO warrants a point release.

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: fix for making the Loop contacts tab show and/ or hide when the user logs in or out of FxA

Comment 3

[Mike de Boer [:mikedeboer]]

The thing I don't understand yet is why `browser/components/loop/test/mochitest/browser_toolbar.js` didn't catch this bug... I'm investigating this atm.

Comment 4

[Mike de Boer [:mikedeboer]]

[Tracking Requested - why for this release]: This is impacting the FTU experience for Loop/ Hello direct calling. At the moment the contacts tab does _not_ show immediately after login with an Fx Account, only after a full browser restart.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Can we write a browser chrome test that would have caught this?

Comment 6

[Mike de Boer [:mikedeboer]]

[Tracking Requested - why for this release]: see comment 4.

Comment 7

[Mike de Boer [:mikedeboer]]

Attachment: Patch 2: extend Loop toolbarbutton tests to check for correct panel states upon opening

Comment 8

[Mike de Boer [:mikedeboer]]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #5)
> Can we write a browser chrome test that would have caught this?

Yes, I attached a test update patch just now. I was hinting at this in comment 3.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 8569793 [details] [diff] [review]
Patch v1: fix for making the Loop contacts tab show and/ or hide when the user logs in or out of FxA

Review of attachment 8569793 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, I've given this a few runs through and it looks good.

Comment 10

[Mike de Boer [:mikedeboer]]

Thanks Mark! Pushed to fx-team:

https://hg.mozilla.org/integration/fx-team/rev/52e496c8a9fa
https://hg.mozilla.org/integration/fx-team/rev/cb5051165c85

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/52e496c8a9fa
https://hg.mozilla.org/mozilla-central/rev/cb5051165c85

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

 I know we are tracking this for release and there is probably going to be a 36.0.1.  Can you nominate it for uplift? Thanks!

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

ni Sylvestre to review this bug for inclusion in 36.0.1, which gtb early this week.

Mike - It's preferable to get an uplift request by early Monday so that we can include the fix in 36.0.1 and 37 Beta 2.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

It is on my track list and we exchanged with Liz on this topic, no worries!

Comment 15

[Mike de Boer [:mikedeboer]]

Comment on attachment 8569793 [details] [diff] [review]
Patch v1: fix for making the Loop contacts tab show and/ or hide when the user logs in or out of FxA

Approval Request Comment
[Feature/regressing bug #]: bug 1121210
[User impact if declined]: After login with FxA, the user won't see the contacts tab inside the Loop panel _until_ he or she restarts the browser. This should happen instantly after login.
[Describe test coverage new/current, TreeHerder]: landed on m-c, adjusted unit tests to fail when this patch is not applied.
[Risks and why]: minor
[String/UUID change made/needed]: n/a

Comment 16

[Mike de Boer [:mikedeboer]]

Comment on attachment 8569960 [details] [diff] [review]
Patch 2: extend Loop toolbarbutton tests to check for correct panel states upon opening

See comment 15 for approval request. This patch contains the updated unit tests mentioned therein.

Comment 17

[Mike de Boer [:mikedeboer]]

Sylvestre, you missed one ;)

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8569793 [details] [diff] [review]
Patch v1: fix for making the Loop contacts tab show and/ or hide when the user logs in or out of FxA

Oups, sorry

Comment 19

[Sylvestre Ledru [:Sylvestre]]

checkin-needed is not needed for branch uplifts.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c1b3c8c553e9
https://hg.mozilla.org/releases/mozilla-aurora/rev/4b51b9e2c088

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d5def3938b6e
https://hg.mozilla.org/releases/mozilla-beta/rev/824656d7ad0d

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/7a4c981abfb6
https://hg.mozilla.org/releases/mozilla-release/rev/608bab8e4868

Comment 23

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 39.0a1 (2015-02-26) using Windows 7 x64.
Verified fixed on Firefox 39.0a1 (2015-03-03), Firefox Dev Edition 38.0a2 (2015-03-03) and Firefox 37 Beta 2 (20150302192546) using Windows 7 x64, Ubuntu 13.10 x64 and Mac OS X 10.8.5.

I have noticed a potential issue: using a clean profile, after the first login with FxA, the Contacts tab appears with a delay of about 3 seconds.
 
Should I file another bug for this issues?

Comment 24

[Mike de Boer [:mikedeboer]]

(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #23)
> I have noticed a potential issue: using a clean profile, after the first
> login with FxA, the Contacts tab appears with a delay of about 3 seconds.
>  
> Should I file another bug for this issues?

Hi Vasilica, thanks for verifying this issue! It's expected that the contacts tab appears with a small delay. The FxA login process isn't the fastest, so no need to file an issue for this.

Comment 25

[Dan Mosedale (:dmosedale, :dmose)]

Mike, would naïve users expect that delay? If not, maybe a new bug suggesting a spinner implementation would make sense… what do you think?

Comment 26

[Mike de Boer [:mikedeboer]]

Hmm, you've got a point but that spinner would need to be on the toolbar button methinks.

Bugs are cheap: bug 1139028

Comment 28

[Vasilica Tamas, QA [:vtamas]]

Verified fixed on Firefox 36.0.1 build 2 (20150305021524) using Windows 7 x64, Ubuntu 14.04 x32 and Mac OS X 10.9.5.

Comment 29

[Sylvestre Ledru [:Sylvestre]]

added to the release notes "36.0.1 - Hello contacts tab did not appear after login with Firefox Account (1137141)"