Closed
Bug 1137141
Opened 8 years ago
Closed 8 years ago
Contacts tab doesn't appear after login with FxA
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox36+ verified, firefox37+ verified, firefox38+ verified, firefox39 verified, relnote-firefox 36+)
People
(Reporter: mikedeboer, Assigned: mikedeboer)
References
Details
Attachments
(2 files)
Patch v1: fix for making the Loop contacts tab show and/ or hide when the user logs in or out of FxA
2.78 KB,
patch
|
standard8
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
Sylvestre
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
2.37 KB,
patch
|
standard8
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
Sylvestre
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
I noticed that the Contacts tab doesn't show and hide anymore after logging in and out with FxA. Only after a browser restart does the tab appear. This is critical and greatly reduces the usability of Loop/ Hello, because there's no way to access the direct calling feature this way.
Flags: qe-verify+
Flags: firefox-backlog+
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
I introduced this bug in my patch for bug : here `shouldComponentUpdate` was introduced for the TabView component in panel.jsx. It checks for changed properties, but only for the components' changed state, not its properties. The `buttonsHidden` property is the one we need to account for, because it determines whether the Contacts tab buttons is shown. This unfortunately affects release, Fx 36, and IMHO warrants a point release.
Blocks: 1121210
Keywords: regression,
regressionwindow-wanted
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8569793 -
Flags: review?(standard8)
Assignee | ||
Updated•8 years ago
|
Priority: -- → P1
Assignee | ||
Comment 3•8 years ago
|
||
The thing I don't understand yet is why `browser/components/loop/test/mochitest/browser_toolbar.js` didn't catch this bug... I'm investigating this atm.
Assignee | ||
Comment 4•8 years ago
|
||
[Tracking Requested - why for this release]: This is impacting the FTU experience for Loop/ Hello direct calling. At the moment the contacts tab does _not_ show immediately after login with an Fx Account, only after a full browser restart.
tracking-firefox36:
--- → ?
Comment 5•8 years ago
|
||
Can we write a browser chrome test that would have caught this?
Flags: needinfo?(mdeboer)
Assignee | ||
Comment 7•8 years ago
|
||
Attachment #8569960 -
Flags: review?(dmose)
Assignee | ||
Comment 8•8 years ago
|
||
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #5) > Can we write a browser chrome test that would have caught this? Yes, I attached a test update patch just now. I was hinting at this in comment 3.
Assignee | ||
Updated•8 years ago
|
Attachment #8569960 -
Flags: review?(standard8)
Updated•8 years ago
|
Updated•8 years ago
|
Rank: 1
Comment 9•8 years ago
|
||
Comment on attachment 8569793 [details] [diff] [review] Patch v1: fix for making the Loop contacts tab show and/ or hide when the user logs in or out of FxA Review of attachment 8569793 [details] [diff] [review]: ----------------------------------------------------------------- Ok, I've given this a few runs through and it looks good.
Attachment #8569793 -
Flags: review?(standard8) → review+
Updated•8 years ago
|
Attachment #8569960 -
Flags: review?(standard8)
Attachment #8569960 -
Flags: review?(dmose)
Attachment #8569960 -
Flags: review+
Assignee | ||
Comment 10•8 years ago
|
||
Thanks Mark! Pushed to fx-team: https://hg.mozilla.org/integration/fx-team/rev/52e496c8a9fa https://hg.mozilla.org/integration/fx-team/rev/cb5051165c85
Comment 11•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/52e496c8a9fa https://hg.mozilla.org/mozilla-central/rev/cb5051165c85
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
I know we are tracking this for release and there is probably going to be a 36.0.1. Can you nominate it for uplift? Thanks!
Flags: needinfo?(mdeboer)
Comment 13•8 years ago
|
||
ni Sylvestre to review this bug for inclusion in 36.0.1, which gtb early this week. Mike - It's preferable to get an uplift request by early Monday so that we can include the fix in 36.0.1 and 37 Beta 2.
Flags: needinfo?(sledru)
Comment 14•8 years ago
|
||
It is on my track list and we exchanged with Liz on this topic, no worries!
Flags: needinfo?(sledru)
Assignee | ||
Comment 15•8 years ago
|
||
Comment on attachment 8569793 [details] [diff] [review] Patch v1: fix for making the Loop contacts tab show and/ or hide when the user logs in or out of FxA Approval Request Comment [Feature/regressing bug #]: bug 1121210 [User impact if declined]: After login with FxA, the user won't see the contacts tab inside the Loop panel _until_ he or she restarts the browser. This should happen instantly after login. [Describe test coverage new/current, TreeHerder]: landed on m-c, adjusted unit tests to fail when this patch is not applied. [Risks and why]: minor [String/UUID change made/needed]: n/a
Flags: needinfo?(mdeboer)
Attachment #8569793 -
Flags: approval-mozilla-release?
Attachment #8569793 -
Flags: approval-mozilla-beta?
Attachment #8569793 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 16•8 years ago
|
||
Comment on attachment 8569960 [details] [diff] [review] Patch 2: extend Loop toolbarbutton tests to check for correct panel states upon opening See comment 15 for approval request. This patch contains the updated unit tests mentioned therein.
Attachment #8569960 -
Flags: approval-mozilla-release?
Attachment #8569960 -
Flags: approval-mozilla-beta?
Attachment #8569960 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
Attachment #8569960 -
Flags: approval-mozilla-release?
Attachment #8569960 -
Flags: approval-mozilla-release+
Attachment #8569960 -
Flags: approval-mozilla-beta?
Attachment #8569960 -
Flags: approval-mozilla-beta+
Attachment #8569960 -
Flags: approval-mozilla-aurora?
Attachment #8569960 -
Flags: approval-mozilla-aurora+
Comment 18•8 years ago
|
||
Comment on attachment 8569793 [details] [diff] [review] Patch v1: fix for making the Loop contacts tab show and/ or hide when the user logs in or out of FxA Oups, sorry
Flags: needinfo?(sledru)
Attachment #8569793 -
Flags: approval-mozilla-release?
Attachment #8569793 -
Flags: approval-mozilla-release+
Attachment #8569793 -
Flags: approval-mozilla-beta?
Attachment #8569793 -
Flags: approval-mozilla-beta+
Attachment #8569793 -
Flags: approval-mozilla-aurora?
Attachment #8569793 -
Flags: approval-mozilla-aurora+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 20•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c1b3c8c553e9 https://hg.mozilla.org/releases/mozilla-aurora/rev/4b51b9e2c088
Comment 21•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/d5def3938b6e https://hg.mozilla.org/releases/mozilla-beta/rev/824656d7ad0d
Comment 22•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-release/rev/7a4c981abfb6 https://hg.mozilla.org/releases/mozilla-release/rev/608bab8e4868
Comment 23•8 years ago
|
||
I was able to reproduce this issue on Firefox 39.0a1 (2015-02-26) using Windows 7 x64. Verified fixed on Firefox 39.0a1 (2015-03-03), Firefox Dev Edition 38.0a2 (2015-03-03) and Firefox 37 Beta 2 (20150302192546) using Windows 7 x64, Ubuntu 13.10 x64 and Mac OS X 10.8.5. I have noticed a potential issue: using a clean profile, after the first login with FxA, the Contacts tab appears with a delay of about 3 seconds. Should I file another bug for this issues?
Status: RESOLVED → VERIFIED
Flags: needinfo?(mdeboer)
Assignee | ||
Comment 24•8 years ago
|
||
(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #23) > I have noticed a potential issue: using a clean profile, after the first > login with FxA, the Contacts tab appears with a delay of about 3 seconds. > > Should I file another bug for this issues? Hi Vasilica, thanks for verifying this issue! It's expected that the contacts tab appears with a small delay. The FxA login process isn't the fastest, so no need to file an issue for this.
Flags: needinfo?(mdeboer)
Comment 25•8 years ago
|
||
Mike, would naïve users expect that delay? If not, maybe a new bug suggesting a spinner implementation would make sense… what do you think?
Assignee | ||
Comment 26•8 years ago
|
||
Hmm, you've got a point but that spinner would need to be on the toolbar button methinks. Bugs are cheap: bug 1139028
Comment 28•8 years ago
|
||
Verified fixed on Firefox 36.0.1 build 2 (20150305021524) using Windows 7 x64, Ubuntu 14.04 x32 and Mac OS X 10.9.5.
Comment 29•8 years ago
|
||
added to the release notes "36.0.1 - Hello contacts tab did not appear after login with Firefox Account (1137141)"
relnote-firefox:
--- → 36+
You need to log in
before you can comment on or make changes to this bug.
Description
•