1137188 - "Write your message" field and send button

Status: VERIFIED FIXED

(support.mozilla.org :: BuddyUp, defect)

Description

[Anthony Ricaud (:rik)]

Page 13

Comment 1

[Anthony Ricaud (:rik)]

From bug 1137226 comment 2, we can look at page 18 and 22 of the 1.4 spec (https://bugzilla.mozilla.org/attachment.cgi?id=8577155)

Comment 2

[Rehan Dalal (Inactive)]

Attachment: https://github.com/mozilla/buddyup/pull/124

Comment 3

[Anthony Ricaud (:rik)]

Comment on attachment 8581865 [details] [review]
https://github.com/mozilla/buddyup/pull/124

Code looks ok but I intended this bug to also take care of the send button style which it is not yet.

Comment 4

[Anthony Ricaud (:rik)]

Rehan: The border for the top of the field and the button will also be needed when we display the "sign in" button. I'm working on the button in bug 1137202 but I won't include the border since it should be the container of the field and "sign in" button that should have this style I believe.

Comment 5

[Anthony Ricaud (:rik)]

Note for review: We should pay attention if it fixes bug 1137105.

Comment 7

[Anthony Ricaud (:rik)]

Comment on attachment 8581865 [details] [review]
https://github.com/mozilla/buddyup/pull/124

I see several issues with this:
- Button icon is too small, we should bump the font-size.
- The button icon shouldn't be vertically centred. That makes it move upwards when the text expands.
- Instead of overriding building blocks, we should do <a href=""> and have less problems.
- Comment 4 was not addressed.
- There is a weird shadow at the top of the textarea added by the system. background: none fixes it.
- The bottom of the placeholder text in the field is cutoff. We should a min-height.

Comment 8

[Anthony Ricaud (:rik)]

Comment on attachment 8581865 [details] [review]
https://github.com/mozilla/buddyup/pull/124

r+ with the margin/padding change.