Show short_name when installing an app that provides one in the manifest

VERIFIED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::System
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: sfoster, Assigned: benfrancis)

Tracking

unspecified
2.2 S7 (6mar)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
When an app's manifest provides a 'short_name' property, users will see that instead of the name in the homescreen, task manager and Settings. To avoid we should show this as well or instead of the name in the install prompt and confirmation
(Reporter)

Comment 1

3 years ago
*To avoid [confusion] we should show...

Also, we should do the same in uninstall UI. 

My understanding is that when defined, we should show short name only, not both.
security related.
blocking-b2g: --- → 2.2+
(Assignee)

Updated

3 years ago
Assignee: nobody → bfrancis
blocking-b2g: 2.2+ → ---
feature-b2g: --- → 2.2+
Will need uplift approval for this. Will flag bajaj for her awareness
Flags: needinfo?(bbajaj)
Created attachment 8573406 [details] [review]
[gaia] benfrancis:1137501 > mozilla-b2g:master
(Assignee)

Comment 5

3 years ago
Comment on attachment 8573406 [details] [review]
[gaia] benfrancis:1137501 > mozilla-b2g:master

Added a method to the manifest helper to save duplicating the logic everywhere. We could probably use this elsewhere too.
Attachment #8573406 - Flags: review?(kgrandon)
I left a comment on the pull request. This looks good, but I would prefer for a more generic naming of the method. What do you think?
Flags: needinfo?(bfrancis)
(Reporter)

Updated

3 years ago
Blocks: 1140060
(Assignee)

Comment 7

3 years ago
Thanks, addressed review comment, ready for re-review.
Flags: needinfo?(bfrancis) → needinfo?(kgrandon)
Comment on attachment 8573406 [details] [review]
[gaia] benfrancis:1137501 > mozilla-b2g:master

Looks good to me, thanks!
Flags: needinfo?(kgrandon)
Attachment #8573406 - Flags: review?(kgrandon) → review+
It looks like there's a linter error, but it may be infra related. Going to add checkin-needed to see what autolander does (it shouldn't land if the linter fails).
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#7qCrc3gMQ9a9uioalrP_Bw

The pull request failed to pass integration tests. It could not be landed, please try again.
I believe the csslint error was fixed here: https://github.com/mozilla-b2g/gaia/commit/4c38360375ae2692ffc4e644bd3f56a2bf58c002

Adding checkin-needed again as I think it should rebase against master.
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#oZEsk_qaRWSbW7i2Ea8ARg

The pull request failed to pass integration tests. It could not be landed, please try again.
I am not sure here. Ben - can you rebase this against master?
Flags: needinfo?(bfrancis)
(Assignee)

Comment 14

3 years ago
Done.
Flags: needinfo?(bfrancis)
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Please uplift to 2.2. Thanks.
Flags: needinfo?(bfrancis)
(In reply to Hermes Cheng[:hermescheng] from comment #16)
> Please uplift to 2.2. Thanks.

Hermes, you can ask for 2.2 approval yourself.
(Reporter)

Comment 18

3 years ago
Comment on attachment 8573406 [details] [review]
[gaia] benfrancis:1137501 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 'short_name' property of web app manifest feature (bug 1001861)
[User impact] if declined: User may see different names for an app when the install it vs. how it appears on the homescreen and elsewhere in the UI
[Testing completed]: Tested on device, new unit test + Gaia-Try is green
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: None

(Fabrice, yes, but the developer has more context for filling out the approval request comment)
Flags: needinfo?(bfrancis)
Attachment #8573406 - Flags: approval-gaia-v2.2?
(Reporter)

Updated

3 years ago
Blocks: 1142572

Updated

3 years ago
Flags: needinfo?(bbajaj)
Attachment #8573406 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Target Milestone: --- → 2.2 S8 (20mar)
v2.2: https://github.com/mozilla-b2g/gaia/commit/322526116ae4f679583e39de400283bd8b60afd9
status-b2g-v2.2: --- → fixed
status-b2g-master: --- → fixed
Target Milestone: 2.2 S8 (20mar) → 2.2 S7 (6mar)
Verified with below builds:

*2.2
Build ID               20150329162502
Gaia Revision          473cd63f53c855299b719285d9b95e3f2910782f
Gaia Date              2015-03-27 20:14:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4b13c4254e2f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.200030
Firmware Date          Sun Mar 29 20:00:41 EDT 2015
Bootloader             L1TC000118D0

*master
Build ID               20150329160203
Gaia Revision          67ad91f3f660b1f16b354ee4c5159ddc5a74d149
Gaia Date              2015-03-28 10:02:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/385840329d91
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.191719
Firmware Date          Sun Mar 29 19:17:28 EDT 2015
Bootloader             L1TC100118D0
Status: RESOLVED → VERIFIED
status-b2g-v2.2: fixed → verified
status-b2g-master: fixed → verified
You need to log in before you can comment on or make changes to this bug.