1137501 - Show short_name when installing an app that provides one in the manifest

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Sam Foster [:sfoster] (he/him)]

When an app's manifest provides a 'short_name' property, users will see that instead of the name in the homescreen, task manager and Settings. To avoid we should show this as well or instead of the name in the install prompt and confirmation

Comment 1

[Sam Foster [:sfoster] (he/him)]

*To avoid [confusion] we should show...

Also, we should do the same in uninstall UI. 

My understanding is that when defined, we should show short name only, not both.

Comment 2

[Gregor Wagner [:gwagner]]

security related.

Comment 3

[Candice Serran (:cserran)]

Will need uplift approval for this. Will flag bajaj for her awareness

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] benfrancis:1137501 > mozilla-b2g:master

Comment 5

[Ben Francis [:benfrancis]]

Comment on attachment 8573406 [details] [review]
[gaia] benfrancis:1137501 > mozilla-b2g:master

Added a method to the manifest helper to save duplicating the logic everywhere. We could probably use this elsewhere too.

Comment 6

[Kevin Grandon :kgrandon]

I left a comment on the pull request. This looks good, but I would prefer for a more generic naming of the method. What do you think?

Comment 7

[Ben Francis [:benfrancis]]

Thanks, addressed review comment, ready for re-review.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8573406 [details] [review]
[gaia] benfrancis:1137501 > mozilla-b2g:master

Looks good to me, thanks!

Comment 9

[Kevin Grandon :kgrandon]

It looks like there's a linter error, but it may be infra related. Going to add checkin-needed to see what autolander does (it shouldn't land if the linter fails).

Comment 10

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#7qCrc3gMQ9a9uioalrP_Bw

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 11

[Kevin Grandon :kgrandon]

I believe the csslint error was fixed here: https://github.com/mozilla-b2g/gaia/commit/4c38360375ae2692ffc4e644bd3f56a2bf58c002

Adding checkin-needed again as I think it should rebase against master.

Comment 12

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#oZEsk_qaRWSbW7i2Ea8ARg

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 13

[Kevin Grandon :kgrandon]

I am not sure here. Ben - can you rebase this against master?

Comment 14

[Ben Francis [:benfrancis]]

Done.

Comment 15

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/4c6cecb14e5cc20b2e217d5783e8dde4a5145d66

Comment 16

[Hermes Cheng (inactive after July 27, 2015)]

Please uplift to 2.2. Thanks.

Comment 17

[[:fabrice] Fabrice Desré]

(In reply to Hermes Cheng[:hermescheng] from comment #16)
> Please uplift to 2.2. Thanks.

Hermes, you can ask for 2.2 approval yourself.

Comment 18

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8573406 [details] [review]
[gaia] benfrancis:1137501 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 'short_name' property of web app manifest feature (bug 1001861)
[User impact] if declined: User may see different names for an app when the install it vs. how it appears on the homescreen and elsewhere in the UI
[Testing completed]: Tested on device, new unit test + Gaia-Try is green
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: None

(Fabrice, yes, but the developer has more context for filling out the approval request comment)

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/322526116ae4f679583e39de400283bd8b60afd9

Comment 20

[Hermes Cheng (inactive after July 27, 2015)]

Verified with below builds:

*2.2
Build ID               20150329162502
Gaia Revision          473cd63f53c855299b719285d9b95e3f2910782f
Gaia Date              2015-03-27 20:14:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4b13c4254e2f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.200030
Firmware Date          Sun Mar 29 20:00:41 EDT 2015
Bootloader             L1TC000118D0

*master
Build ID               20150329160203
Gaia Revision          67ad91f3f660b1f16b354ee4c5159ddc5a74d149
Gaia Date              2015-03-28 10:02:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/385840329d91
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.191719
Firmware Date          Sun Mar 29 19:17:28 EDT 2015
Bootloader             L1TC100118D0