1137511 - MDSM can start buffering 1s earlier than necessary when audio frames have been pushed to audio hardware but not yet played

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Bobby Holley (:bholley)]

This was exposed by the tests I wrote in bug 1136399.

OutOfDecodedAudio() is overly-simplistic, and doesn't consider the fact that we can have a bit more than 1s of audio in the hardware buffer. I've got a patch that seems to do the trick.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Account for audio frames already pushed to audio hardware but not yet played when computing OutOfDecodedAudio. v1

Comment 2

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=098a64f8a733

Comment 3

[Bobby Holley (:bholley)]

(In reply to Bobby Holley (:bholley) from comment #2)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=098a64f8a733

The oranges in the try push were a test that I pushed alongside this patch and wasn't ready yet. Aside from that this is green.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3148c577bfd9

Comment 4

[Bobby Holley (:bholley)]

This could improve our MTBR stats on YouTube. Let's consider uplifting after it bakes a bit.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3148c577bfd9

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8570202 [details] [diff] [review]
Account for audio frames already pushed to audio hardware but not yet played when computing OutOfDecodedAudio. v1

Requesting uplift approval for 38 and 37b3 since this is a low risk fix to a high priority issue.

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Unnecessary rebuffering pauses during youtube playback.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: Risk looks low. This just adds another condition to deciding we're out of audio data and need to request more.
[String/UUID change made/needed]: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f61a5c023ec1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/729cf69ef43f