1181913 - Data race in AudioSink::mWritten

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

1. mWritten is written at [1] on the audio thread without decoder monitor held.
2. mWritten is read at [2] on the state machine thread with decoder monitor held.

[1] https://hg.mozilla.org/mozilla-central/file/e7e69cc8c07b/dom/media/AudioSink.cpp#l217
[2] https://hg.mozilla.org/mozilla-central/file/e7e69cc8c07b/dom/media/AudioSink.cpp#l119

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ab6968a63bf

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1181913_fix_mWritten_data_race_v1.patch

Make mWritten an Atomic<int64_t>.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e5a81baa18b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2e5a81baa18b