Closed Bug 1181913 Opened 6 years ago Closed 6 years ago

Data race in AudioSink::mWritten

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

1. mWritten is written at [1] on the audio thread without decoder monitor held.
2. mWritten is read at [2] on the state machine thread with decoder monitor held.

[1] https://hg.mozilla.org/mozilla-central/file/e7e69cc8c07b/dom/media/AudioSink.cpp#l217
[2] https://hg.mozilla.org/mozilla-central/file/e7e69cc8c07b/dom/media/AudioSink.cpp#l119
Make mWritten an Atomic<int64_t>.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8631935 - Flags: review?(kinetik)
Attachment #8631935 - Flags: review?(kinetik) → review+
Thanks for the review!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2e5a81baa18b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.