1137822 - Request to add gaia-l10n builds for Luganda, Twsana and Ukrainian locales on master, 2.2, 2.1, 2.0

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Delphine Lebédel [:delphine - Use needinfo]]

Please add gaia-l10n builds for Luganda (lg), Twsana (tn) and Ukrainian (uk) locales on master, 2.2, 2.1, 2.0 once repos are set up.

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Actually, Ukrainian will only be on master and 2.2.
Luganda and Tswana: master, 2.2, 2.1, 2.0

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] Delphine:bug-1137822-patch-master/2.2 > mozilla-b2g:master

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Comment on attachment 8570697 [details] [review]
[gaia] Delphine:bug-1137822-patch-master/2.2 > mozilla-b2g:master

Stas, can you take a look when you have time? Just adding locales :)

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

Asking for review now, but won't land until all repos are set up and populated.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] Delphine:bug-1137822-add-lg-tn-uk-locales-to-2.0 > mozilla-b2g:v2.0

Comment 6

[Théo Chevalier]

Pushed README to:

https://hg.mozilla.org/gaia-l10n/lg/rev/4a97515c7682
https://hg.mozilla.org/releases/gaia-l10n/v2_1/lg/rev/4a97515c7682
https://hg.mozilla.org/releases/gaia-l10n/v2_0/lg/rev/4a97515c7682

https://hg.mozilla.org/gaia-l10n/tn/rev/7dac20290099
https://hg.mozilla.org/releases/gaia-l10n/v2_1/tn/rev/7dac20290099
https://hg.mozilla.org/releases/gaia-l10n/v2_0/tn/rev/7dac20290099


https://hg.mozilla.org/gaia-l10n/uk was not empty.

Now safe to add to builds ;)

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

thanks for the Readmes Théo :D

Comment 8

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 9

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 10

[Delphine Lebédel [:delphine - Use needinfo]]

ni on Stas so he can land this manually. Sorry for the hassle!

Comment 11

[Staś Małolepszy :stas]

I think I can merge the master one, but do we need proper approvals for the other ones?  It might be best to request approvals and ask sheriffs to land on 2.2 and 2.1 (specifying a different PR for 2.1 uplift).  I think it's possible, while creating pull requests to explicitly define which branch you're creating it against, so maybe try this?

Also, I'm going to be on vacation starting tomorrow, so might not be able to carry this to completion.

Comment 12

[Delphine Lebédel [:delphine - Use needinfo]]

Yes I plan to ask for approvals for the other ones. thanks Stas!

Comment 13

[Delphine Lebédel [:delphine - Use needinfo]]

Fabrice: since Stas is out he couldn't carry this to completion. Would you mind landing my patch on master please? thanks

Comment 14

[[:fabrice] Fabrice Desré]

I merged the first PR to master: https://github.com/mozilla-b2g/gaia/commit/ce327cf9eca7e583376b5f29b66df14f18015a89

Comment 15

[Delphine Lebédel [:delphine - Use needinfo]]

Comment on attachment 8570697 [details] [review]
[gaia] Delphine:bug-1137822-patch-master/2.2 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none. Just adding languages to fxOS
[User impact] if declined: missing languages
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): minimal
[String changes made]: none

Comment 16

[Delphine Lebédel [:delphine - Use needinfo]]

Comment on attachment 8570709 [details] [review]
[gaia] Delphine:bug-1137822-add-lg-tn-uk-locales-to-2.0 > mozilla-b2g:v2.0

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none - just adding missing languages
[User impact] if declined: missing languages
[Testing completed]: 
[Risk to taking this patch] (and alternatives if risky): minimal
[String changes made]: none

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none - just adding missing languages
[User impact] if declined: missing languages
[Testing completed]: 
[Risk to taking this patch] (and alternatives if risky): minimal
[String changes made]: none

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/f559bdc8a0ae64088b2a2c8c79654fe828407f6d
v2.1: https://github.com/mozilla-b2g/gaia/commit/ea97a87048a4c1e2a479bbea1d75e0a182b2c4c9
v2.0: https://github.com/mozilla-b2g/gaia/commit/8463d1c9142f32c8ea175048dac52e41620443ce

Comment 18

[Delphine Lebédel [:delphine - Use needinfo]]

Thanks all! :D