1138095 - Fix in-tree consumers that use non-standard flag argument of String.prototype.{search,match,replace} in mail/.

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Tooru Fujisawa [:arai]]

(same as bug 1131107)

Before fixing bug 1108382, we need to replace all of them with regexp literal, new RegExp(...) or .split().join().

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Do not use non-standard flag argument of String.prototype.replace in mail/.

Fixed String.prototype.replace call sites to use regexp literals.

at least no regression on try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7a729c78766a

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8570975 [details] [diff] [review]
Do not use non-standard flag argument of String.prototype.replace in mail/.

Review of attachment 8570975 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thx! r=mkmelin

Comment 3

[Tooru Fujisawa [:arai]]

Thank you! :D

https://hg.mozilla.org/comm-central/rev/da5fd11104e5