Editing search keywords isn't obvious

NEW
Unassigned

Status

()

Firefox
Preferences
3 years ago
2 years ago

People

(Reporter: patrickjdempsey, Unassigned)

Tracking

({ux-discovery})

36 Branch
ux-discovery
Points:
---
Bug Flags:
firefox-backlog ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150217132925

Steps to reproduce:

Click search magnifier button, select Change Search Settings.  The UI for the search plugins includes a column for keywords, but there is no way to change search keywords in that UI.  



Expected results:

There should be a button for Edit Keyword like in the old Manage Search Engines UI.

Updated

3 years ago
Keywords: ux-discovery

Updated

3 years ago
Blocks: 1106559
Status: UNCONFIRMED → NEW
Component: Untriaged → Preferences
Ever confirmed: true

Comment 1

3 years ago
You can double-click the column. Maybe single-click would be more obvious. But I don't think an edit button is the best UX here.
Summary: No way to set search keyword from Search Settings → Editing search keywords isn't obvious
How about stating "click to edit" on hovering the row?

Apart of that mouse-less editing isn't possible as it used to be.

Comment 3

3 years ago
(In reply to XtC4UaLL [:xtc4uall] from comment #2)
> How about stating "click to edit" on hovering the row?
We could also update the description. It currently says "The search bar lets you search alternate engines directly. Choose which ones to display.".
It doesn't really mention you can reorder the engines with drag and drop, or that you can edit keywords.

> Apart of that mouse-less editing isn't possible as it used to be.
The keyboard question was raised in bug 1106055 for reordering engines, but never was for the keyword editing. Firefox could provide shortcuts for these things.

Needinfo'ing UX about these things.
Flags: needinfo?(philipp)
(In reply to XtC4UaLL [:xtc4uall] from comment #2)

> Apart of that mouse-less editing isn't possible as it used to be.

Press <enter> to start editing the keyword of the selected row.
(Reporter)

Comment 5

3 years ago
Neither the double-click nor pressing Enter is obvious, intuitive, or "discoverable".  I clicked on the entries, I right-clicked on the entries, I hovered over the entries... and nothing happened.  
At the bare-minimum, right-clicking the entry should give the options to Edit or Delete. 

I also don't understand why a button isn't the "best UX" here... it worked for ages in the Manage Search Engines dialog and it's certainly more obvious than having to use an obscure mouse operation on a specific part of a tree... something that TMK doesn't happen anywhere else in the Firefox UI.  Sounds like some kind of OSX nonsense to me.
Created attachment 8573181 [details]
mock

Agreed that this is a problem. We could reveal the affordance to edit when hovering the row and change the trigger to a single click directly onto the text field (note: not the entire row).

There's a mockup attached.
Flags: needinfo?(philipp)

Updated

3 years ago
Flags: firefox-backlog?
OS: Windows 7 → All
Hardware: x86_64 → All

Comment 7

3 years ago
Is this a dup of bug 1113616?

Regardless, the UI for Search prefs needs to improve.  Adding keywords is not obvious (nor is removing them).  Showing some sort of UI indicator which would draw the user to clicking on it to add a keyword is needed.

Reordering the search engines is easy enough once you know how to do it.  I believe a simple text message is all that is needed. e.g. "Drag to reorder the search engines."
Duplicate of this bug: 1113616

Comment 9

3 years ago
(In reply to patrickjdempsey from comment #5)
> Neither the double-click nor pressing Enter is obvious, intuitive, or
> "discoverable".  I clicked on the entries, I right-clicked on the entries, I
> hovered over the entries... and nothing happened.
> At the bare-minimum, right-clicking the entry should give the options to
> Edit or Delete.

Agreed, and this is also a problem on **Debian Iceweasel 38.2.0**.

I followed the same steps as you, except that I also tried double-clicking on the row of the search engine whose keyword I wanted to edit!

Eventually gave up and came here (bugs.mozilla.org), ready to file a bug report stating that the option to edit search keywords had been removed: seemingly a regression.

I was very surprised to discover, from the reply you got, that double-clicking *in a non-delineated area at the right-hand end of the relevant row* would work. That is a location that has zero UI indication that it will respond:

- to a double-click, and
- differently to the rest of the row.

> I also don't understand why a button isn't the "best UX" here... it worked
> for ages in the Manage Search Engines dialog and it's certainly more obvious
> than having to use an obscure mouse operation on a specific part of a
> tree... something that TMK doesn't happen anywhere else in the Firefox UI. 
> Sounds like some kind of OSX nonsense to me.

Again, agreed. When it comes to figuring out how to edit search keywords, the current UI is liable to cause users who aren't persistent to give up, and to cause users who are persistent to spend much longer than ought to be necessary.

Comment 10

2 years ago
It's totally not bloody obvious. Especially since I tried double clicking like crazy, except I was hovering over search engine name, not the keyword area..

Comment 11

2 years ago
(In reply to Florian Quèze [:florian] [:flo] from comment #4)
> (In reply to XtC4UaLL [:xtc4uall] from comment #2)
> 
> > Apart of that mouse-less editing isn't possible as it used to be.
> 
> Press <enter> to start editing the keyword of the selected row.

Pressing enter doesn't work at all. 

I am on 48.0a1 (2016-03-11).
You need to log in before you can comment on or make changes to this bug.