1138244 - Contact display name changes don't propagate to open conversations

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[aleth [:aleth]]

In particular the tab title and the conv top displayname don't change.

Comment 1

[aleth [:aleth]]

Attachment: namechange.diff

Free bonus: also fixes bug 955687.

Comment 2

[aleth [:aleth]]

Attachment: namechange.diff v2

The 'buddy' in the conversation binding is the account buddy not the buddy, so I changed what we are observing to reflect that.

Comment 3

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #2)
> The 'buddy' in the conversation binding is the account buddy not the buddy,
> so I changed what we are observing to reflect that.

To clarify: this refers to the change from v1 to v2.

Really we should probably be observing contact-display-name-changed instead of the accountbuddy, and make sure the displayName of the contact is used everywhere rather than that of the accountbuddy. But what's in this patch is consistent with the status quo of the conversation binding.

Comment 4

[Patrick Cloke [:clokep]]

When do we expect to NOT have a tab, but have a conversation binding? (I.e. why add all the |if (tab)| checks?)

Comment 5

[Florian Quèze [:florian]]

(In reply to Patrick Cloke [:clokep] from comment #4)
> When do we expect to NOT have a tab, but have a conversation binding? (I.e.
> why add all the |if (tab)| checks?)

The original reason for that was to make the conversation.xml binding self contained, so that add-ons could re-use it to build other alternative UIs.

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/85c0fdad7658