Running search-provider.js on node.js

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: rickychien, Assigned: rickychien)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Blocks: 955988
No longer depends on: 955999
Created attachment 8571731 [details] [review]
[gaia] RickyChien:search-provider-to-nodejs > mozilla-b2g:master
(Assignee)

Comment 2

4 years ago
Comment on attachment 8571731 [details] [review]
[gaia] RickyChien:search-provider-to-nodejs > mozilla-b2g:master

George, 

I found search-provider.js was added recently but it failed with `make RUN_ON_NODE=1`. I fixed it along with some of coding style improvements (e.g. move out all comment of pre-app.js in order to keep updating latest comment inside module.js rather than other places.)
Attachment #8571731 - Flags: review?(gduan)
Comment on attachment 8571731 [details] [review]
[gaia] RickyChien:search-provider-to-nodejs > mozilla-b2g:master

r=gduan, thanks!!
Attachment #8571731 - Flags: review?(gduan) → review+
(Assignee)

Comment 4

4 years ago
Landed in master:

https://github.com/mozilla-b2g/gaia/commit/ec5b81c0ae3b2a7536fdf4abc587cb66455cd771
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.