Closed
Bug 1138773
Opened 9 years ago
Closed 9 years ago
Running search-provider.js on node.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect, P1)
Firefox OS Graveyard
Gaia::Build
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rickychien, Assigned: rickychien)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•9 years ago
|
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8571731 [details] [review] [gaia] RickyChien:search-provider-to-nodejs > mozilla-b2g:master George, I found search-provider.js was added recently but it failed with `make RUN_ON_NODE=1`. I fixed it along with some of coding style improvements (e.g. move out all comment of pre-app.js in order to keep updating latest comment inside module.js rather than other places.)
Attachment #8571731 -
Flags: review?(gduan)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8571731 [details] [review] [gaia] RickyChien:search-provider-to-nodejs > mozilla-b2g:master r=gduan, thanks!!
Attachment #8571731 -
Flags: review?(gduan) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Landed in master: https://github.com/mozilla-b2g/gaia/commit/ec5b81c0ae3b2a7536fdf4abc587cb66455cd771
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
Priority: -- → P1
You need to log in
before you can comment on or make changes to this bug.
Description
•