Closed Bug 1138773 Opened 10 years ago Closed 10 years ago

Running search-provider.js on node.js

Categories

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

Attachments

(1 file)

[gaia] RickyChien:search-provider-to-nodejs > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gduan
: review+
Details | Review
No description provided.
Blocks: 955988
No longer depends on: 955999
Comment on attachment 8571731 [details] [review] [gaia] RickyChien:search-provider-to-nodejs > mozilla-b2g:master George, I found search-provider.js was added recently but it failed with `make RUN_ON_NODE=1`. I fixed it along with some of coding style improvements (e.g. move out all comment of pre-app.js in order to keep updating latest comment inside module.js rather than other places.)
Attachment #8571731 - Flags: review?(gduan)
Comment on attachment 8571731 [details] [review] [gaia] RickyChien:search-provider-to-nodejs > mozilla-b2g:master r=gduan, thanks!!
Attachment #8571731 - Flags: review?(gduan) → review+
Landed in master: https://github.com/mozilla-b2g/gaia/commit/ec5b81c0ae3b2a7536fdf4abc587cb66455cd771
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: