955999 - Running webapp-zip.js on node.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

+++ This bug was initially created as a clone of Bug #955988 +++

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR

George, PR has submitted for zip functionality. Unfortunately, I ran into a strange bug when passing too long args into nsIProcess. It throws exception only in zipping settings and system app. Thus, a workaround fix is follow with this patch. I've commented on NodeHelper() function for further information.

Please review patiently, also unzip application.zip to verify.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

I saw there is an incorrect permission in unzip folder. However, I found it has been addressed by JSZip in newer commit [1] and it works for me locally. Filed an issue [2] to notify JSZip and waiting for newer version coming.

[1] https://github.com/Stuk/jszip/commit/bb4984daaf55ee32f5c3317075f2f034acc98bec
[2] https://github.com/Stuk/jszip/issues/204

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8573978 [details] [review]
Gaia PR

I don't see problem in your commit and the result of file diff looks good. r=gduan.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/d705c4a9dbdaa63f37f2c440cc3d40f2810a027b