Closed
Bug 1138824
Opened 9 years ago
Closed 9 years ago
Avoid installing import libraries in $(DIST)/lib
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox39 fixed)
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(3 files)
1.97 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
1.38 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
3.42 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Apart from nspr and nss, which use old rules that do use $(DIST)/lib, our build system is now using in-obj-tree libraries directly when linking. We thus don't need the libraries under $(DIST)/lib anymore.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8571830 -
Flags: review?(gps)
Assignee | ||
Comment 2•9 years ago
|
||
The recursivemake backend sets IMPORT_LIBRARY to the same value as SHARED_LIBRARY on non-Windows platforms, so we can simply use IMPORT_LIBRARY everywhere. This is not required per se because this part of the makefile is going to be removed in part 3, but it makes a hunk of part 3 clearer.
Attachment #8571832 -
Flags: review?(gps)
Assignee | ||
Comment 3•9 years ago
|
||
However, still keep copying nss there, because its build system needs it to link programs such as certutil.
Attachment #8571833 -
Flags: review?(gps)
Updated•9 years ago
|
Attachment #8571830 -
Flags: review?(gps) → review+
Updated•9 years ago
|
Attachment #8571832 -
Flags: review?(gps) → review+
Updated•9 years ago
|
Attachment #8571833 -
Flags: review?(gps) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a049b3a7e08 https://hg.mozilla.org/integration/mozilla-inbound/rev/33ac0758a1f6 https://hg.mozilla.org/integration/mozilla-inbound/rev/9d23ce7d6739
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1a049b3a7e08 https://hg.mozilla.org/mozilla-central/rev/33ac0758a1f6 https://hg.mozilla.org/mozilla-central/rev/9d23ce7d6739
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•