1165442 - VS2015 LINK : fatal error LNK1104: cannot open file 'mozglue.lib'

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(Away)]

0:29.30 link -nologo -DLL -SUBSYSTEM:WINDOWS -DYNAMICBASE -LIBPATH:C:/build2/msys/s/vs2015/obj/vs2015/dist/lib -DEFAULTLIB:mozglue -OUT:libs -DEBUG -OPT:REF -OUT:C:/build2/msys/s/vs2015/obj/vs2015/security/nss/lib/ckfw/builtins/nssckbi.dll -DEBUG -OPT:REF -DEF:C:/build2/msys/s/vs2015/obj/vs2015/security/nss/lib/ckfw/builtins/nssckbi.def  -MAP  C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\security\\nss\\lib\\ckfw\\builtins\\anchor.obj C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\security\\nss\\lib\\ckfw\\builtins\\constants.obj C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\security\\nss\\lib\\ckfw\\builtins\\bfind.obj C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\security\\nss\\lib\\ckfw\\builtins\\binst.obj C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\security\\nss\\lib\\ckfw\\builtins\\bobject.obj C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\security\\nss\\lib\\ckfw\\builtins\\bsession.obj C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\security\\nss\\lib\\ckfw\\builtins\\bslot.obj C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\security\\nss\\lib\\ckfw\\builtins\\btoken.obj C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\security\\nss\\lib\\ckfw\\builtins\\certdata.obj C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\security\\nss\\lib\\ckfw\\builtins\\ckbiver.obj  C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\dist\\lib\\nssckfw.lib C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\dist\\lib\\nssb.lib  C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\dist\\lib\\plc4.lib C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\dist\\lib\\plds4.lib C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\dist\\lib\\nspr4.lib    C:\\build2\\msys\\s\\vs2015\\obj\\vs2015\\security\\nss\\lib\\ckfw\\builtins\\nssckbi.res
 0:29.32 C:/build2/msys/s/vs2015/obj/vs2015/_virtualenv/Scripts/python.exe C:/build2/msys/s/vs2015/config/nsinstall.py -t -m 644 C:/build2/msys/s/vs2015/obj/vs2015/security/nss/cmd/certutil/certutil.pdb C:/build2/msys/s/vs2015/obj/vs2015/dist/bin
 0:29.37 LINK : fatal error LNK1104: cannot open file 'mozglue.lib'

My mozglue.lib is under dist/sdk/lib, but this link is looking for it in dist/lib.

From irc:
<glandium> dmajor: there are two problems. One is that bug 1138824 didn't make the necessary change to config/external/nss/Makefile.in, which, in practice means building with mingw is likely broken
<glandium> the other, and it's more important, is that you don't have MOZ_CRT defined

Comment 1

[(Away)]

What are the necessary changes to config/external/nss/Makefile.in? I'd like to remove that problem before diving into the MOZ_CRT stuff.

Comment 2

[Mike Hommey [:glandium]]

Replace the LIBPATH with $(ABS_DIST)/../mozglue/build

Comment 3

[(Away)]

Attachment: Fix LIBPATH for NSS

This works! The build finishes, and Firefox launches successfully. I observed calls to mozglue!je_malloc from both xul.dll and nss3.dll.

Given what you told me about MOZ_CRT, I don't understand why this works.

Comment 4

[Mike Hommey [:glandium]]

We may want this uplifted to the branches where bug 1138824 is. That can land with a=npotb, that codepath is not used for firefox builds as we do them.

Comment 5

[Mike Hommey [:glandium]]

(In reply to David Major [:dmajor] from comment #3)
> Created attachment 8607175 [details] [diff] [review]
> Fix LIBPATH for NSS
> 
> This works! The build finishes, and Firefox launches successfully. I
> observed calls to mozglue!je_malloc from both xul.dll and nss3.dll.

I'd expect things to work, mostly, without MOZ_CRT, because most malloc/free will properly go through jemalloc. The problem we had is rooted to how the CRT itself is using malloc and free. Please read the comment in mozglue/crt/Makefile.in. This might not apply to the new CRT in 2015, but we have to make sure of it.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dffde8b2633a

Comment 7

[(Away)]

Aha, so here's why MOZ_CRT is not defined:
> C:\Program Files (x86)\Microsoft Visual Studio 14.0>dir /s /b crtdll.*
> File Not Found

Looks like there has been some refactoring for 2015. For example, the code that calls static initializers and DllMain is now in VC\crt\src\vcruntime\dll_dllmain.cpp.

Also, VS2015 opt builds define _malloc_crt/_free_crt to _malloc_base/_free_base. Those are actual functions exported from ucrtbase.dll. Does that mean the end of the yucky library hack?

Comment 8

[Mike Hommey [:glandium]]

(In reply to David Major [:dmajor] from comment #7)
> Does that mean the end of the yucky library hack?

Maybe it does. Or maybe it means worse problems. We'll see, I guess.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dffde8b2633a

Comment 10

[(Away)]

(In reply to Mike Hommey [:glandium] from comment #4)
> We may want this uplifted to the branches where bug 1138824 is. That can
> land with a=npotb, that codepath is not used for firefox builds as we do
> them.

Ryan could I ask you to land this for me? My m-a and m-b trees aren't handy at the moment.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ff24813408e7

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/07f9d8abe2ea