Closed Bug 1138845 Opened 5 years ago Closed 5 years ago

Gtk+3 builds on elm can't run tests

Categories

(Core :: Disability Access APIs, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

See bug 1110211 comment 7 and following.
This partially backs out bug 1110211, and makes us use atk-bridge dynamically. If libgtk3 uses atk-bridge, it's linked against it, and we get the atk_bridge_adaptor_init symbol through it. If it's not, then it means it's using an old at-spi2-atk stack, and that comes with a gtk-3.0/modules/libatk-brige.so that we load instead.

Note that I haven't tested if a11y actually works with this patch because I don't know what to check, but I did check that:
- recent gtk3 does have a dependency on atk-bridge that would make the weak symbol resolved.
- elm builds with this patch applied has the same test results as a try build with bug 1110211 backed out. (Sadly, debug tests are crashing in both cases, but that's a different story)
Attachment #8571859 - Flags: review?(tbsaunde+mozbugs)
(In reply to Mike Hommey [:glandium] from comment #1)
> (Sadly, debug tests are crashing in both cases, but that's a different story)

In fact, they were crashing before, too, but the color of the jobs changed from orange to red for some reason. Retriggering old jobs that were orange before bug 1110211 turned them red.
> Note that I haven't tested if a11y actually works with this patch because I
> don't know what to check, but I did check that:

I'd only check that starting firefox with Orca running causes stuff to be spoken (at least that's the simplest test).  I checked that is the case for gtk using libatk-bridge-2.so, but I haven't checked the other configuration.  I don't think very early gtk 3.x is terribly important accessibility was laking in early gnome 3 releases aiui, but at some point we should be sure it at least doesn't dead lock or crash.
Attachment #8571859 - Flags: review?(tbsaunde+mozbugs) → review+
https://hg.mozilla.org/mozilla-central/rev/04100ea63002
https://hg.mozilla.org/mozilla-central/rev/8f7ebc7006b3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.