Browser crashes when service worker calls cache.matchAll without parameters. These parameters are optional so it can be call without any.
Thanks Oscar! I believe I know what this is. When I added the WorkerFeature to Cache I used assertions to check that a feature is only added once to each actor. This doesn't quite hold for the stream control actor because each one manages multiple streams. The tests did not catch this because the matchAll() is likely done on main thread and not worker. There is a separate bug to improve test coverage. I'll have a patch shortly.
Assignee: nobody → bkelly
Component: DOM: Workers → DOM
Andrea, There is a small bug in the WorkerFeature code I wrote for Cache. I assumed each actor would only ever get a Feature added once. This doesn't hold for the CacheStreamControlChild, though, as it may be controlling multiple ReadStream objects. This patch fixes the issue by permitting a duplicate SetFeature() as long as the later Feature objects are identical to the first Feature.
Attachment #8571979 - Flags: review?(amarchesini)
Note, I verified this test triggers the reported assertion as well.
Attachment #8571979 - Flags: review?(amarchesini) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Now matchAll without parameters is working. Thanks bkelly.
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.