Closed Bug 1139004 Opened 5 years ago Closed 4 years ago

Rename all "Character Encoding" to "Text Encoding" in Help content (Toolkit bug 951695)

Categories

(SeaMonkey :: Help Documentation, defect)

defect
Not set

Tracking

(seamonkey2.37 fixed, seamonkey2.38 verified, seamonkey2.39 fixed, seamonkey2.40 fixed)

RESOLVED FIXED
seamonkey2.37
Tracking Status
seamonkey2.37 --- fixed
seamonkey2.38 --- verified
seamonkey2.39 --- fixed
seamonkey2.40 --- fixed

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

()

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #951695 +++

> Chrome and Internet Explorer name this entry "Encoding". Alternatively we
> could align with Safari which names it "Text Encoding".

Toolkit has changed to "Text Encoding" in toolkit/locales/en-US/chrome/global/charsetMenu.dtd which breaks suite/common/charsetOverlay.xul and thus at least needs to be changed here. Either we fork charsetMenu.dtd and its two entities to retain the old labels, or have to modify the workding throughout preference panes and Help content.
Depends on: 1138964
Since bug 1138964 covers the bustage in suite/ as well already (thanks to Paenglab!), I'm retargeting this bug to make the respective changes in the Help content.
Component: UI Design → Help
Summary: Consider renaming "Character Encoding" to "Text Encoding" (Toolkit bug 951695) → Rename all "Character Encoding" to "Text Encoding" in Help content (Toolkit bug 951695)
(In reply to neil@parkwaycc.co.uk from bug 1138964 comment #10)
> (There's also the Page Info change...)

Neil, comm-central changeset ecc95ada09d1 didn't address generalEncoding and formEncoding in suite/locales/en-US/chrome/browser/pageInfo.dtd, thus I'll change those as drive-by fix here (unless there is a reason not to change those labels).
Never mind, I've filed bug 1140204 for that.
Depends on: 1140204
Attached patch Proposed patchSplinter Review
Note that I'm also changing the link anchors, thus had to modify mailPrefsOverlay.xul respectively.
Attachment #8577661 - Flags: review?(iann_bugzilla)
Attachment #8577661 - Flags: review?(iann_bugzilla) → review+
Thanks Ian, push for comm-central please.
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/3e9818b98a34
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.37
Comment on attachment 8577661 [details] [diff] [review]
Proposed patch

>+++ b/suite/locales/en-US/chrome/common/help/nav_help.xhtml

>+<p>A text encoding method is the way how characters in a document or message
Sorry, only just spotted this but it should either be "the way" or "how" but not both.

>+  are converted to data to be used by your computer. All web documents and
>+  mail or news messages use a text encoding method (also known as a character
>+  set, character coding, or charset).</p>
Removed the "how" and rewrapped the paragraph.
Attachment #8632551 - Flags: review?(iann_bugzilla)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8632551 [details] [diff] [review]
Fix wording from changeset 3e9818b98a34

Thanks, a=me for CLOSED TREE too
Attachment #8632551 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Whiteboard: [c-n: attachment 8632551 for comm-central]
Keywords: checkin-needed
Whiteboard: [c-n: attachment 8632551 for comm-central]
Hmm, the follow-up patch checked in long ago, thus I'm not sure why this bug is still open.
Closing as it's definitely fixed on all versions.
Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.