If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Perfherder UI reloads every time we change state

RESOLVED FIXED

Status

Tree Management
Perfherder
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Currently we reload the entire UI if we change the state at all. This is pretty annoying, especially when just toggling some minor thing (e.g. bug 1134774).

It should be possible to avoid this behaviour (just changing the URL along with the state) with Angular's deferIntercept function:

http://stackoverflow.com/a/24835569

Unfortunately getting the right incantation seems to be difficult. Working on it...

Comment 1

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/09e0975674237ae6e5d1af5c13673f67826b6903
Bug 1139204 - Don't reload UI every time we change state

Previously we were relying on URL routing to propagate changes when
a user added/removed/showed/hid a series (or changed the time interval).
This was pretty slow and annoying. Instead, just update the URL and
change just change the thing we need to change. Note that to make
this work, we have to import an in-development copy on angular-ui-router
with the deferIntercept function.
I don't think there's anyone who could really give useful review feedback on this atm, so I just committed it. It only affects the perfherder visualization layer, nothing else in treeherder.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 3

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/9c103fe19c550c249fc02ec8ed7b86a5453cf5b9
Bug 1139204 - Fix color matching when deleting a series

Comment 4

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/2a9380ff5ff52b8754f4a31cea6901fd94571b67
Bug 1139204 - Fix one more minor bug

Updated

3 years ago
Assignee: nobody → wlachance

Comment 5

2 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ddc646feb0ccf1a43654f133c24141ce69f0d522
Bug 1139204 - Don't reload UI every time we change state

Previously we were relying on URL routing to propagate changes when
a user added/removed/showed/hid a series (or changed the time interval).
This was pretty slow and annoying. Instead, just update the URL and
change just change the thing we need to change. Note that to make
this work, we have to import an in-development copy on angular-ui-router
with the deferIntercept function.

https://github.com/mozilla/treeherder/commit/9050cdd5b6b7e0912661dc96c98852aad401fd4e
Bug 1139204 - Fix color matching when deleting a series

https://github.com/mozilla/treeherder/commit/6cf1fda953621875e6c98af32d59f5fd7120ddea
Bug 1139204 - Fix one more minor bug
You need to log in before you can comment on or make changes to this bug.