1139631 - Smarter test defaults

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

> I actually think these 3 settings (lockscreen.enabled, ftu.manifestURL,
> screen.timeout) should be set at these values by default. Only some tests
> (FTU, LockScreen) would need to set them back to some other values.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1139631_integration_defaults > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8572885 [details] [review]
[gaia] KevinGrandon:bug_1139631_integration_defaults > mozilla-b2g:master

Tim - I was hoping you could review this gaia-wide patch for me and save people time so I don't have to flag every app peer. Though if you do feel there is value in flagging app peers I can do so, I just didn't think this patch needed it. Thanks!

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Comment on attachment 8572885 [details] [review]
[gaia] KevinGrandon:bug_1139631_integration_defaults > mozilla-b2g:master

I left some questions but as long as the build is green I guess my questions about "is lockscreen necessary here?" are useless :)

Comment 4

[Kevin Grandon :kgrandon]

(In reply to Julien Wajsberg [:julienw] (PTO March 7th -> 15th) from comment #3)
> I left some questions but as long as the build is green I guess my questions
> about "is lockscreen necessary here?" are useless :)

Thanks - actually they were useful. I took a closer look at the tests, and some of them were constructed around the lockscreen. So the tests were passing, but we were bypassing some useful assertions. I've fixed these tests.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8572885 [details] [review]
[gaia] KevinGrandon:bug_1139631_integration_defaults > mozilla-b2g:master

Thanks for the clean-up.

Comment 6

[Kevin Grandon :kgrandon]

Thanks for the review. Rebased and have a green on gaia-try, so going to try landing this.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/b96850646d82550218d419200534f931675d06f1