Closed Bug 1139757 Opened 7 years ago Closed 7 years ago

marionette-profile-builder fails when merging strings

Categories

(Testing Graveyard :: JSMarionette, defect)

Product:
Testing Graveyard
Component:
JSMarionette
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(4 files)

Pull request - Fix profile builder merging
64 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
[gaia-node-modules] KevinGrandon:bug_1139757_update_marionette_profile_builder > mozilla-b2g:master
57 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
[gaia] KevinGrandon:bug_1139757_node_modules > mozilla-b2g:master
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
[gaia] KevinGrandon:bug_1139757_node_modules_2 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
Details | Review 
TypeError: Cannot read property '0' of null
    at mergeOptions (/Users/kevin/workspace/gaia/node_modules/marionette-profile-builder/index.js:31:17)
    at mergeOptions (/Users/kevin/workspace/gaia/node_modules/marionette-profile-builder/index.js:32:21)
    at mergeOptions (/Users/kevin/workspace/gaia/node_modules/marionette-profile-builder/index.js:32:21)
Blocks: 1139631
Comment on attachment 8573031 [details] [review]
Pull request - Fix profile builder merging

Got a verbal review from :lightsofapollo.
Attachment #8573031 - Flags: review+
Comment on attachment 8573407 [details] [review]
[gaia-node-modules] KevinGrandon:bug_1139757_update_marionette_profile_builder > mozilla-b2g:master

Simple package.json bump, r=me.
Attachment #8573407 - Flags: review+
Comment on attachment 8573408 [details] [review]
[gaia] KevinGrandon:bug_1139757_node_modules > mozilla-b2g:master

R=me for package.json bump.
Attachment #8573408 - Flags: review+
In master: https://github.com/mozilla-b2g/gaia/commit/c8c7b485d761ebcfc2d762f882133833baa8026f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.