Closed Bug 1139749 Opened 5 years ago Closed 5 years ago

backport bug 1128853 to bmo (Bugzilla shouldn't try to write API tokens into the shadow DB)

Categories

(bugzilla.mozilla.org :: General, defect)

Production
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

References

Details

Attachments

(1 file, 1 obsolete file)

now that there's a proper fix for the api-token shadow-db issue, we should back out bug 1128832 and backport bug 1128853
Attached patch 1139749_1.patch (obsolete) β€” β€” Splinter Review
lots of merge conflicts, but nothing particularly interesting in this backport.
would like another set of eyes on it regardless :)
Attachment #8573025 - Flags: review?(dkl)
Will we also need to add the generate_api_token=1 to all of the relevant extension templates such as extensions/BMO/template/en/default/bug/create/create-*? Also some other templates use js/{bug,field}.js and will need to be audited as well.
Flags: needinfo?(glob)
yup, no idea how i missed that.  will update next week.
Flags: needinfo?(glob)
Attachment #8573025 - Attachment is obsolete: true
Attachment #8573025 - Flags: review?(dkl)
Blocks: 1096798
Attached patch 1139749_2.patch β€” β€” Splinter Review
Attachment #8574536 - Flags: review?(dkl)
Comment on attachment 8574536 [details] [diff] [review]
1139749_2.patch

Review of attachment 8574536 [details] [diff] [review]:
-----------------------------------------------------------------

Good. r=dkl
Attachment #8574536 - Flags: review?(dkl) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   ef96ae1..8875246  master -> master
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.