1140023 - Updates to MozReview testing environment

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Gregory Szorc [:gps]]

I'm making some updates to the MozReview testing environment. Filing a bug to track the reviews.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1140023/gps

/r/4781 - reviewboard: don't create excessive bugs during tests
/r/4783 - testing: add target_people to dumpreview output

Pull down these commits:

hg pull review -r a561a92b0f299c1a0d69450ccba64773ed6243bf

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8573380 [details]
MozReview Request: bz://1140023/gps

/r/4781 - reviewboard: don't create excessive bugs during tests
/r/4783 - testing: add target_people to dumpreview output
/r/4797 - testing: move make_admin into MozReviewBoard class
/r/4799 - testing: print submitter username in dumpreview output
/r/4801 - mozreview: eliminate NO_BUGZILLA_AUTH variable
/r/4803 - testing: create and use adminbugzilla alias
/r/4805 - testing: remove "reviewboard create" command
/r/4807 - mozreview: convert test-auth.t to have default user

Pull down these commits:

hg pull review -r b17015d9bd13ccc28a8f65b520fed229c13bd338

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8573380 [details]
MozReview Request: bz://1140023/gps

/r/4781 - mozreview: don't create excessive bugs during tests
/r/4783 - mozreview: add target_people to dumpreview output
/r/4797 - testing: move make_admin into MozReviewBoard class
/r/4799 - mozreview: print submitter username in dumpreview output
/r/4801 - mozreview: eliminate NO_BUGZILLA_AUTH variable
/r/4803 - mozreview: create and use adminbugzilla alias
/r/4805 - testing: remove "reviewboard create" command
/r/4807 - mozreview: convert test-auth.t to have default user
/r/4871 - mozreview: create a default user as part of commonenv
/r/4873 - bzexport: don't use admin user in tests
/r/4875 - bzpost: don't use admin user in tests
/r/4877 - testing: make the admin user an admin in Review Board

Pull down these commits:

hg pull review -r c41aad47fe8bbd8ff1147d3464a1cff23130a4f3

Comment 4

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4781/#review3967

Mostly just did a skim review of this, as it should all be pretty mechanical. Ship It.

Comment 5

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4783/#review3969

I just reviewed this commit as part of Bug 1138687. (Only comment is maybe we also want target_groups eventually too)

Comment 6

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4797/#review3971

::: testing/vcttesting/reviewboard/mach_commands.py
(Diff revision 2)
> -        elif 'BUGZILLA_HOME' is os.environ:
> +        elif 'BUGZILLA_HOME' is os.environ and path:

`is`? that seems super strange to me. supposed to be `in`?

Comment 7

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4799/#review3973

Wow ya, huge improvement :D Ship It!

Comment 8

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4801/#review3975

Ship It!

Comment 9

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4803/#review3977

::: hgext/bzexport/tests/helpers.sh
(Diff revision 2)
> +alias adminbugzilla='BUGZILLA_USERNAME=[e-mail] BUGZILLA_PASSWORD=password $TESTDIR/bugzilla'

I wonder if it's worth putting together a test writing guide that lists all the little helpers, mach commands, credentials, etc used in these tests.

Would be a great reference when you're writing a new test and don't want to have to search through all the .t files to find similar things.

Comment 10

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4805/#review3979

Ship It!

Comment 11

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4807/#review3981

Ship It!

Comment 12

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4871/#review3983

Ship It!

Comment 13

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4873/#review3985

Seems fine to me. I'm not super familiar with bzexport though, so you might want to have someone more familiar / a bugzilla person comment on the NEW vs ASSIGNED stuff.

Comment 14

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4875/#review3987

Ship It!

Comment 15

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/4877/#review3989

Ship It!

Comment 16

[Steven MacLeod [:smacleod]]

Comment on attachment 8573380 [details]
MozReview Request: bz://1140023/gps

https://reviewboard.mozilla.org/r/4779/#review3991

Ship It!

Comment 17

[Gregory Szorc [:gps]]

The bzexport changed test output is the only major concern here. Looking at the test, I think the new behavior is appropriate. (I actually remember thinking this output was weird when I wrote the tests.)

The only issue is target_groups missing from dumpreview. That's easy enough to add later.

Comment 20

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: don't create excessive bugs during tests

Comment 21

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: create and use adminbugzilla alias

Comment 22

[Gregory Szorc [:gps]]

Attachment: MozReview Request: testing: remove "reviewboard create" command

Comment 23

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: create a default user as part of commonenv

Comment 24

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bzexport: don't use admin user in tests

Comment 25

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bzpost: don't use admin user in tests

Comment 26

[Gregory Szorc [:gps]]

Attachment: MozReview Request: testing: make the admin user an admin in Review Board

Comment 27

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: convert test-auth.t to have default user

Comment 28

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: add target_people to dumpreview output

Comment 29

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: eliminate NO_BUGZILLA_AUTH variable

Comment 30

[Gregory Szorc [:gps]]

Attachment: MozReview Request: testing: move make_admin into MozReviewBoard class

Comment 31

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: print submitter username in dumpreview output