1140153 - [STK] Icon format not compliant with the new data format of confirmMessage/callMessage from SET_UP_CALL/LAUNCH_BROWSER

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Anshul]

In bug 1091454 the data format of confirmMessage/callMessage from SET_UP_CALL and LAUNCH_BROWSER proactive commands was changed but Gaia still doesn't support the new format, nor provides backwards compatibility for the icons.The functin STK_CMD_LAUNCH_BROWSER in icc_worker.js at [1] still uses options.icons instead of options.confirmMessage.icons.

[1] http://lxr.mozilla.org/gaia/source/apps/system/js/icc_worker.js#152

Comment 1

[bhavana bajaj [:bajaj]]

NI Bevis to help look at this.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

It seems that implementation in bug 1016807 didn't follow the format of MozStkSetUpCall & MozStkBrowserSetting defined in MozStkCommandEvent.webidl properly.

Where confirmMessage/callMessage in MozStkSetUpCall & MozStkBrowserSetting are defined as:
dictionary MozStkTextMessage : MozStkIconContainer
{
  DOMString text;
  MozStkDuration duration;
  boolean isHighPriority;
  boolean userClear;
  boolean responseNeeded;
};

dictionary MozStkIconContainer
{
  boolean iconSelfExplanatory;
  sequence<MozStkIcon> icons;
};

NI the assignee of bug 1016807 to check this instead.

Comment 3

[Kai-Chih Hu [:khu]]

Wesley, does it mean that this bug will be reviewed by Comms team who will try to find an owner? Thanks.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] mancas:bug1140153 > mozilla-b2g:master

Comment 5

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8578579 [details] [review]
[gaia] mancas:bug1140153 > mozilla-b2g:master

Now it should work as expected. Can you review this when you get a chance, Tim?

Anshul could you test and check if everything is ok?

Thanks =)

Comment 7

[Anshul]

Comment on attachment 8578579 [details] [review]
[gaia] mancas:bug1140153 > mozilla-b2g:master

Edgar, the original issue reported is resolved with your patch. However with your patch, the confirm message text is not displayed. Instead icc-confirmCall-defaultmessage is getting displayed. Please find the snapshots attached with and without your patch.

Comment 8

[Anshul]

Attachment: default_confirm_msg_with_proposed_patch

Comment 9

[Anshul]

Attachment: confirm_msg_without_proposed_patch

Comment 10

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8578579 [details] [review]
[gaia] mancas:bug1140153 > mozilla-b2g:master

Good catch! It was my fault. Now, it should be fixed, would you mind testing it again please?

Comment 11

[Anshul]

Comment on attachment 8578579 [details] [review]
[gaia] mancas:bug1140153 > mozilla-b2g:master

The patch seems to be working as expected.

Comment 12

[Inder]

Looks like we have the fix, can we please land it asap.

Comment 13

[Maria Angeles Oteo (:oteo)]

It needs to be reviewed first.

Tim, Manuel asked you to review this patch, can you have a look at it, please? Let's know if you can`t to look for another reviewer. Thanks

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8578579 [details] [review]
[gaia] mancas:bug1140153 > mozilla-b2g:master

Is the code testable?

Comment 15

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#7qc4fnQmSs6VxCBpOHrUuQ

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 16

[Mike Lee [:mlee]]

Hi Maria,

Please address the auto-land failure below:

(In reply to Autolander from comment #15)
> http://docs.taskcluster.net/tools/task-graph-inspector/
> #7qc4fnQmSs6VxCBpOHrUuQ
> 
> The pull request failed to pass integration tests. It could not be landed,
> please try again.


Thanks,
Mike

Comment 17

[Maria Angeles Oteo (:oteo)]

Manu, can you have a look at the auto-lander failure that Mike points in comment 16? Thanks a lot!

Comment 18

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/7ec7f3ef52d04451b8ca1600cbdf9df4e5ca0ac3

Comment 19

[Anshul]

Comment on attachment 8578579 [details] [review]
[gaia] mancas:bug1140153 > mozilla-b2g:master

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/f256681138d7ad7455d14c2497218354d3057a09