1140169 - (menu-polish) [meta] Overflow menu UI polish

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: 2015-03-05 23.04.40.png

We've taken a couple passes at this in bug 1055536, and some other ones that I can't seem to find right now but I'm still noticing a lot of visual issues. Let's try to clean these up! Especially the left edge transparency issue.

Namely:
 - Pressed state should be "Toolbar grey pressed" (#D7D7DC)
 - Left edge of menu is noticeably transparent ( you can see the characters from the page coming through)
 - Add 15dp left padding to labels (I don't think I ever specified this value anywhere but 15dp would keep it consistent in other areas of our UI that are close to "edges")
 - Dividers in between each row seem to be (#C9D3DC), we should update this to (#D7D9DB) like our toolbar divider.

Chenxia, maybe we could also use the same shadow that we're working on in bug 1137921?

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

- height of each list item to 48dp (same height as the toolbar)

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: Screen Shot 2015-03-17 at 10.12.15 AM.png

Attaching screenshot of the edge transparency issue.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_overflowmenu_polish.png

Attaching preview of the changes I mentioned earlier.

Again, lower priority for sure - but I wanted to file this before I forgot. It's also been bugging me in my dreams.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Leaving a note here, looked at this with Mcomella and the left edge is totally crisp on his N4. Something weird is happening here..

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I've pulled at a thread, meta-fying and regrouping to figure out appropriate next steps.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Unassign from meta.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Unfixed bugs moved to fennec-polish meta: closing this.