Closed Bug 1140197 Opened 9 years ago Closed 8 years ago

Allow user to toggle Safebrowsing feature in setting app

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86
Linux
defect
Not set
normal

Tracking

(tracking-b2g:backlog, ux-b2g:2.3, b2g-master fixed)

RESOLVED FIXED
2.6 S10 - 3/25
tracking-b2g backlog
ux-b2g 2.3
Tracking Status
b2g-master --- fixed

People

(Reporter: yu-yamamoto, Unassigned, NeedInfo)

References

Details

Attachments

(3 files)

In Bug 839120, we've gotten safebrowsing feature on gecko side of FxOS.
Although, the user can't change the status of that feature, because there are no toggle of the safebrowsing on settings app(I mean, we can't toggle to enable/disable that feature).

Then, I'd like to propose that how about adding the safebrowsing "toggle" on setting app.
Hi Fabien,

How about this settings feature.
I think, this feature will make users be happy. 

It's happy for me to get some opinion.
I think you are module owner of settings, then I'm setting NI to you.
Let me know if I'm wrong.
Flags: needinfo?(fabien)
To continue discussion on tracking bug #1149867, 
Peter says
> UX, the platform work for support safebrowsing is done.  To complete it, we just need a gaia spec for settings.  I think it should be pretty straightforward.  Can someone take a look at it?

We'd like to continue to implement this feature, then we just need UX spec for settings app.
Flags: needinfo?(firefoxos-ux-bugzilla)
[Tracking Requested - why for this release]:

This isn't currently on the roadmap for 2.x or 3.0. Flagging for backlog for now.
ux-b2g: --- → 2.3
Flags: needinfo?(firefoxos-ux-bugzilla)
Hopefully this is pretty simple here. As far as I know, we basically just need two toggles, "Block attack sites" and "Block web forgeries". (In deskt

Two main options come to mind here:

Option A: Add toggle under existing "Browsing Privacy" menu item

Option B: Add a new top level menu called "Browsing Security", add it under there. 


A couple thoughts:
- I'm not fussed either option. (Options B looks cluttered, BUT the privacy controls option is going away, which might reduce clutter)
- Note tracking protection is coming too (bug 1154605) and it will likely have a similar UX.
- Both options should be enabled by default 

What do you think?
(In reply to Paul Theriault [:pauljt] from comment #4)
> Created attachment 8592652 [details]
> Sketch of proposed options
> 
> Hopefully this is pretty simple here. As far as I know, we basically just
> need two toggles, "Block attack sites" and "Block web forgeries". (In deskt
> 
> Two main options come to mind here:
> 
> Option A: Add toggle under existing "Browsing Privacy" menu item
> 
> Option B: Add a new top level menu called "Browsing Security", add it under
> there. 
> 
> 
> A couple thoughts:
> - I'm not fussed either option. (Options B looks cluttered, BUT the privacy
> controls option is going away, which might reduce clutter)
> - Note tracking protection is coming too (bug 1154605) and it will likely
> have a similar UX.
> - Both options should be enabled by default 
> 
> What do you think?

For Option A, we could rename "Browsing Privacy" to "Browsing Safety" - since that encompasses both. (Thx Francois)
(In reply to Stephany Wilkes from comment #3)
> [Tracking Requested - why for this release]:
> 
> This isn't currently on the roadmap for 2.x or 3.0. Flagging for backlog for
> now.

What do you think of the above? Who do we need approval from here in terms of UX approval?
Flags: needinfo?(swilkes)
My comment was in response to a spec being needed for Settings app. Right now, nothing is well defined enough beyond 2.2 (which this won't make) for me to be able to assign people to specific efforts to design specs. 

If it's a matter of incremental changes in Settings, Jenny can handle it, as she's UX for Settings.
Flags: needinfo?(swilkes) → needinfo?(jelee)
I personally would keep browsing related settings in the same panel and rename the panel title.
Needinfo Francis on this as he owns Browser and Browsing settings, thanks Francis =)
Flags: needinfo?(jelee) → needinfo?(fdjabri)
I'm happy with Paul's suggestion in comment #5 - let's rename the setting to "Browsing Safety" and include privacy and security under there.
Flags: needinfo?(fdjabri)
I'll give it a try. first pass is already on github
Assignee: nobody → fbraun
Re-assigning to Jonathan as his first Gaia bug.
Assignee: fbraun → jkingston
Tests failure is expected because we need to make the preference default to match the setting.
See Also: → 1249874
Attachment #8719780 - Flags: review?(gasolin)
Thanks for the patch. Do you need default value for browser.safebrowsing.malware.enabled and browser.safebrowsing.enabled settings? If so please edit build/config/common-settings.json to change the default settings value
Flags: needinfo?(jkingston)
@Fred Ah I thought the pref binding in: https://bugzilla.mozilla.org/show_bug.cgi?id=1248626 would be enough thanks for showing me that.
I have pushed a new commit to github now thanks.
Flags: needinfo?(jkingston)
Comment on attachment 8719780 [details] [review]
[gaia] jonathanKingston:bug-1140197-safe-browser-toggle > mozilla-b2g:master

Looks good, thanks.

Please make sure it does not cause treeherder gij tests fail before merge
Attachment #8719780 - Flags: review?(gasolin) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/0ca84e6846bc8dcbd643a5d3f2df6692909e5ee9
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S10 - 3/25
Assignee: jkt → nobody
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: