1140197 - Allow user to toggle Safebrowsing feature in setting app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Yusuke Yamamoto]

In Bug 839120, we've gotten safebrowsing feature on gecko side of FxOS.
Although, the user can't change the status of that feature, because there are no toggle of the safebrowsing on settings app(I mean, we can't toggle to enable/disable that feature).

Then, I'd like to propose that how about adding the safebrowsing "toggle" on setting app.

Comment 1

[Yusuke Yamamoto]

Hi Fabien,

How about this settings feature.
I think, this feature will make users be happy. 

It's happy for me to get some opinion.
I think you are module owner of settings, then I'm setting NI to you.
Let me know if I'm wrong.

Comment 2

[Yusuke Yamamoto]

To continue discussion on tracking bug #1149867, 
Peter says
> UX, the platform work for support safebrowsing is done.  To complete it, we just need a gaia spec for settings.  I think it should be pretty straightforward.  Can someone take a look at it?

We'd like to continue to implement this feature, then we just need UX spec for settings app.

Comment 3

[Stephany Wilkes]

[Tracking Requested - why for this release]:

This isn't currently on the roadmap for 2.x or 3.0. Flagging for backlog for now.

Comment 4

[Paul Theriault [:pauljt] (no longer reading bugmail)]

Attachment: Sketch of proposed options

Hopefully this is pretty simple here. As far as I know, we basically just need two toggles, "Block attack sites" and "Block web forgeries". (In deskt

Two main options come to mind here:

Option A: Add toggle under existing "Browsing Privacy" menu item

Option B: Add a new top level menu called "Browsing Security", add it under there. 


A couple thoughts:
- I'm not fussed either option. (Options B looks cluttered, BUT the privacy controls option is going away, which might reduce clutter)
- Note tracking protection is coming too (bug 1154605) and it will likely have a similar UX.
- Both options should be enabled by default 

What do you think?

Comment 5

[Paul Theriault [:pauljt] (no longer reading bugmail)]

(In reply to Paul Theriault [:pauljt] from comment #4)
> Created attachment 8592652 [details]
> Sketch of proposed options
> 
> Hopefully this is pretty simple here. As far as I know, we basically just
> need two toggles, "Block attack sites" and "Block web forgeries". (In deskt
> 
> Two main options come to mind here:
> 
> Option A: Add toggle under existing "Browsing Privacy" menu item
> 
> Option B: Add a new top level menu called "Browsing Security", add it under
> there. 
> 
> 
> A couple thoughts:
> - I'm not fussed either option. (Options B looks cluttered, BUT the privacy
> controls option is going away, which might reduce clutter)
> - Note tracking protection is coming too (bug 1154605) and it will likely
> have a similar UX.
> - Both options should be enabled by default 
> 
> What do you think?

For Option A, we could rename "Browsing Privacy" to "Browsing Safety" - since that encompasses both. (Thx Francois)

Comment 6

[Paul Theriault [:pauljt] (no longer reading bugmail)]

(In reply to Stephany Wilkes from comment #3)
> [Tracking Requested - why for this release]:
> 
> This isn't currently on the roadmap for 2.x or 3.0. Flagging for backlog for
> now.

What do you think of the above? Who do we need approval from here in terms of UX approval?

Comment 7

[Stephany Wilkes]

My comment was in response to a spec being needed for Settings app. Right now, nothing is well defined enough beyond 2.2 (which this won't make) for me to be able to assign people to specific efforts to design specs. 

If it's a matter of incremental changes in Settings, Jenny can handle it, as she's UX for Settings.

Comment 8

[Jenny Lee]

I personally would keep browsing related settings in the same panel and rename the panel title.
Needinfo Francis on this as he owns Browser and Browsing settings, thanks Francis =)

Comment 9

[Francis Djabri [:djabber]]

I'm happy with Paul's suggestion in comment #5 - let's rename the setting to "Browsing Safety" and include privacy and security under there.

Comment 10

[Frederik Braun [:freddy]]

I'll give it a try. first pass is already on github

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] mozfreddyb:bug-1140197-safebrowsing-gaia > mozilla-b2g:master

Comment 12

[Frederik Braun [:freddy]]

Re-assigning to Jonathan as his first Gaia bug.

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] jonathanKingston:bug-1140197-safe-browser-toggle > mozilla-b2g:master

Comment 14

[Jonathan Kingston [:jkt] he/him]

Tests failure is expected because we need to make the preference default to match the setting.

Comment 15

[[e-mail]]

Thanks for the patch. Do you need default value for browser.safebrowsing.malware.enabled and browser.safebrowsing.enabled settings? If so please edit build/config/common-settings.json to change the default settings value

Comment 16

[Jonathan Kingston [:jkt] he/him]

@Fred Ah I thought the pref binding in: https://bugzilla.mozilla.org/show_bug.cgi?id=1248626 would be enough thanks for showing me that.
I have pushed a new commit to github now thanks.

Comment 17

[[e-mail]]

Comment on attachment 8719780 [details] [review]
[gaia] jonathanKingston:bug-1140197-safe-browser-toggle > mozilla-b2g:master

Looks good, thanks.

Please make sure it does not cause treeherder gij tests fail before merge

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/0ca84e6846bc8dcbd643a5d3f2df6692909e5ee9