1248626 - Mirror the safebrowser preferences with the settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Jonathan Kingston [:jkt] he/him]

Preferences are:

> browser.safebrowsing.malware.enabled
> browser.safebrowsing.enabled

Comment 1

[Jonathan Kingston [:jkt] he/him]

Attachment: bug-1248626.patch

Here is a first attempt at setting the defaults

Comment 2

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8721248 [details] [diff] [review]
bug-1248626.patch

mhenretty are you the right person to review this?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8721248 [details] [diff] [review]
bug-1248626.patch

Review of attachment 8721248 [details] [diff] [review]:
-----------------------------------------------------------------

Please reflag me when this is ready to go :)

Comment 4

[Jonathan Kingston [:jkt] he/him]

Attachment: Preview of the toggles

Comment 5

[Jonathan Kingston [:jkt] he/him]

Attachment: Preview of the error

Comment 6

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8721248 [details] [diff] [review]
bug-1248626.patch

Reflagging as once I got the phone to compile the errors were shown by default the only thing changed in: https://bugzilla.mozilla.org/show_bug.cgi?id=1249874 was the typo visible when the error loads.

This issue blocks: https://bugzilla.mozilla.org/show_bug.cgi?id=1140197 where the work has been done to implement the toggles.

They can be previewed by visiting:
http://itisatrap.org/firefox/its-an-attack.html (malware)
http://itisatrap.org/firefox/its-a-trap.html (forgeries)

Pictures of the toggle and error have been attached.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8721248 [details] [diff] [review]
bug-1248626.patch

Review of attachment 8721248 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Thanks for the pictures, and for working on bug 1249874. I'm rubber stamping this as free to land once bug 1249874 goes in.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/bef27d00850b

Comment 9

[Jonathan Kingston [:jkt] he/him]

To my knowledge this is fixed now. Please reopen if it still exists.