Closed Bug 1140313 Opened 5 years ago Closed 5 years ago

Enable tab sharing option in the builds

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
1

Tracking

(firefox38 verified, firefox39 verified)

VERIFIED FIXED
mozilla39
Iteration:
39.2 - 23 Mar
Tracking Status
firefox38 --- verified
firefox39 --- verified

People

(Reporter: standard8, Assigned: mikedeboer)

References

Details

(Whiteboard: [screensharing])

Attachments

(1 file)

Split out from bug 1131568 as we're not quite ready yet.

IMO we need to fix bug 1137634 and bug 1136871 before we can reasonably turn it on in nightly builds.

We could turn it on for non-e10s only but I'd rather have us scope bug 1137634 first so we can be sure to get that out before e10s is ready for release.
Here is Mike's enabling patch from bug 1131568. r+ for when we've got the blockers resolved as per comment 0.
Attachment #8573802 - Flags: review+
Status: NEW → ASSIGNED
Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/edc1012c711b now all dependencies are resolved.

(Sharing of e10s tabs is not a hard dependency to enable tab sharing on Nightly).
Iteration: --- → 39.2 - 23 Mar
Points: --- → 1
Rank: 15
Flags: firefox-backlog+
Priority: -- → P1
Whiteboard: [screensharing]
https://hg.mozilla.org/mozilla-central/rev/edc1012c711b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment on attachment 8573802 [details] [diff] [review]
Enable the 'Share my Tabs' option for screensharing.

Approval Request Comment
[Feature/regressing bug #]: Loop/ Hello screensharing milestone
[User impact if declined]: User will see a new option that allows her/ him to share a window or Firefox tabs inside a room (aka. conversation).
[Describe test coverage new/current, TreeHerder]: landed on m-c, tests pass.
[Risks and why]: minor
[String/UUID change made/needed]: n/a
Attachment #8573802 - Flags: approval-mozilla-aurora?
Attachment #8573802 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify+
QA Contact: bogdan.maris
Verified that tab sharing is enabled in latest Nightly and latest Aurora, across platforms (Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit).
Status: RESOLVED → VERIFIED
No longer depends on: 1154511
You need to log in before you can comment on or make changes to this bug.