1140313 - Enable tab sharing option in the builds

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Split out from bug 1131568 as we're not quite ready yet.

IMO we need to fix bug 1137634 and bug 1136871 before we can reasonably turn it on in nightly builds.

We could turn it on for non-e10s only but I'd rather have us scope bug 1137634 first so we can be sure to get that out before e10s is ready for release.

Comment 1

[Mark Banner (:standard8)]

Attachment: Enable the 'Share my Tabs' option for screensharing.

Here is Mike's enabling patch from bug 1131568. r+ for when we've got the blockers resolved as per comment 0.

Comment 2

[Mike de Boer [:mikedeboer]]

Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/edc1012c711b now all dependencies are resolved.

(Sharing of e10s tabs is not a hard dependency to enable tab sharing on Nightly).

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/edc1012c711b

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8573802 [details] [diff] [review]
Enable the 'Share my Tabs' option for screensharing.

Approval Request Comment
[Feature/regressing bug #]: Loop/ Hello screensharing milestone
[User impact if declined]: User will see a new option that allows her/ him to share a window or Firefox tabs inside a room (aka. conversation).
[Describe test coverage new/current, TreeHerder]: landed on m-c, tests pass.
[Risks and why]: minor
[String/UUID change made/needed]: n/a

Comment 5

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0b78e34a3347

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Verified that tab sharing is enabled in latest Nightly and latest Aurora, across platforms (Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit).