1140345 - Use an image instead of toolbarbutton for the reading view button

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P5)

Description

[Dão Gottwald [:dao]]

The reader mode button in the location bar is too close to the dropdown arrow as well as adjacent location bar icons when there are any.

This could be fixed by addressing bug 1140340 and reverting most of bug 1131458.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8580975 [details] [diff] [review]
Patch

Review of attachment 8580975 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks good. I think we should show the blue icon for the :active state on Mac for consistency with the other icons around it. Also, could you please rephrase the bug summary so that it relates more obviously to what the patch does?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/f278852df165

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/f278852df165

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8580975 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: reader mode
[User impact if declined]: broken muscle memory for tabbing from location bar to search box
[Describe test coverage new/current, TreeHerder]: landed on central, manual qa testing
[Risks and why]: none expected, uses same approach for location-bar buttons as before
[String/UUID change made/needed]: none

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8580975 [details] [diff] [review]
Patch

(branch patch needed)

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> Comment on attachment 8580975 [details] [diff] [review]
> Patch
> 
> (branch patch needed)

A branch patch might not be needed once bug 1131457 is uplifted.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b7de0775a8d9