1134658 - Reader mode icon looks bad with lightweight themes

Status: VERIFIED FIXED

(Firefox Graveyard :: Reading List, defect, P3)

Description

[Sébastien Desvignes]

Attachment: Reader mode icon with a lightweight theme

The reader mode icon doesn't use transparency and looks bad when using a lightweight theme

Comment 1

[Flore Allemandou [:flore]]

Attachment: reader mode icon is a white square

The darker the theme is, the more you see it.

The icon should have a transparent background.

I was unable to see the bug on Mac OSX, maybe because the transparency on the URL bar is handled differently.

Comment 2

[Andrei Vaida [:avaida]]

(In reply to Flore Allemandou [:flore] from comment #1)
> I was unable to see the bug on Mac OSX, maybe because the transparency on
> the URL bar is handled differently.

I was unable to replicate this issue on Mac OS X 10.9.5 and Ubuntu 14.04 (x64), I believe this is Windows only.

Comment 3

[Flore Allemandou [:flore]]

Hmmm, yeah... My previous comment was not clear.
The screenshot I uploaded showing the bug was done on a windows 7 computer (at work). I checked on my imac (at home) and could not see this bug (even when zooming), but I was not sure if it did not exist or just that I could not see it.

Sorry for being not clear.

Comment 4

[Justin Dolske [:Dolske]]

P3 because it's pretty obvious as primary UI and LWTs are popular. Also, this probably looks really bad on the DevEdition with a black theme?

Comment 6

[Justin Dolske [:Dolske]]

Looking at chrome://browser/skin/[e-mail] / chrome://browser/skin/reader-mode-16.png, they do indeed have a white background. We need versions of these two icons with a transparent background. Should just be a simple image swap.

Comment 8

[Stephen Horlander [:shorlander]]

There is an image attached to bug 1135351 that should fix this too.

Comment 9

[Justin Dolske [:Dolske]]

That would be attachment 8575382 [details], I guess? Can we (a) get that as a PNG in @1x and @2x flavors, and (b) what's the new blue version of the icon for? We currently over have the white/orange version to indicate if reader mode is active or not.

Comment 10

[Florian Quèze [:florian]]

(In reply to Justin Dolske [:Dolske] from comment #9)
> Can we (a) get that as a PNG in @1x and @2x flavors,

Where would this help? Isn't the SVG icon we are currently using better to handle various dpi settings?

> and (b) what's the new blue version of the icon for?

The active state (between the mousedown and mouseup events).

Comment 12

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 39.0a1 (2015-03-29) and Aurora 38.0a2 (2015-03-29), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5, with the Developer Edition and several other lightweight (persona) themes.