configuring with --disable-compile-environment fails on Mac while looking for CoreMedia/CoreMedia.h

RESOLVED FIXED in Firefox 40

Status

()

Core
Build Config
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
mozilla40
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8573887 [details] [diff] [review]
Patch

0:03.59 checking for CoreMedia/CoreMedia.h... no
 0:03.59 configure: error: MacOS X 10.7 SDK or later is required
 0:03.59 ------ config.log ------
 0:03.59 configure:15234: checking for yasm
 0:03.59 configure:16220: checking for application to build
 0:03.59 configure:16378: checking if app-specific confvars.sh exists
 0:03.59 configure:20198: /usr/bin/clang -c  -DNO_X11  conftest.c 1>&5
 0:03.59 configure:20192:10: fatal error: 'linux/ethtool.h' file not found
 0:03.59 #include <linux/ethtool.h>
 0:03.59          ^
 0:03.59 1 error generated.
 0:03.59 configure: failed program was:
 0:03.59 #line 20191 "configure"
 0:03.59 #include "confdefs.h"
 0:03.59 #include <linux/ethtool.h>
 0:03.59 int main() {
 0:03.59  struct ethtool_cmd cmd; cmd.speed_hi = 0;
 0:03.59 ; return 0; }
 0:03.59 configure:20398: checking __attribute__ ((aligned ())) support
 0:03.59 configure:20415: /usr/bin/clang -c  -DNO_X11 -Werror  conftest.c 1>&5
 0:03.59 configure:20482: checking for CoreMedia/CoreMedia.h
 0:03.59 configure:20492:   conftest.c >/dev/null 2>conftest.out
 0:03.59 /Users/florian/buildhg/comm-l10n/mozilla/configure: line 20491: conftest.c: command not found
 0:03.59 configure: failed program was:
 0:03.59 #line 20487 "configure"
 0:03.59 #include "confdefs.h"
 0:03.59 #include <CoreMedia/CoreMedia.h>
 0:03.59 configure: error: MacOS X 10.7 SDK or later is required
 0:03.59 *** Fix above errors and then restart with               "/Applications/Xcode.app/Contents/Developer/usr/bin/make -f client.mk build"
 0:03.59 make: *** [configure] Error 1
Attachment #8573887 - Flags: review?(mh+mozilla)
Attachment #8573887 - Flags: review?(mh+mozilla) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f00a9769470
florian: was there a reason this didn't land?  I pushed a try build just to be safe and set checkin-needed.
Flags: needinfo?(florian)
Keywords: checkin-needed
(Assignee)

Comment 3

3 years ago
(In reply to Nick Alexander :nalexander from comment #2)
> florian: was there a reason this didn't land?

Not a good reason. This patch alone isn't useful to me, because bug 1140365 also needs fixing for --disable-compile-environment to work on comm-central. I haven't had time to address the review comment and test a new patch there.
Flags: needinfo?(florian)
https://hg.mozilla.org/integration/fx-team/rev/80cb5f706116
Status: NEW → ASSIGNED
(In reply to Nick Alexander :nalexander from comment #4)
> https://hg.mozilla.org/integration/fx-team/rev/80cb5f706116

so i guess with that i doesn't need to be checkin-needed anymore.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/80cb5f706116
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.