Closed Bug 1140365 Opened 7 years ago Closed 4 years ago

Incorrect path to nsinstall.py when using --disable-compile-environment in comm-central

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
<srcdir>/obj-l10n/_virtualenv/bin/python <srcdir>/config/nsinstall.py -D ../../dist/install
<srcdir>/obj-l10n/_virtualenv/bin/python: can't open file '<srcdir>/config/nsinstall.py': [Errno 2] No such file or directory

This is attempting to use nsinstall.py from comm-central instead of from comm-central/mozilla.
Attachment #8573891 - Flags: review?(mh+mozilla)
Comment on attachment 8573891 [details] [diff] [review]
Patch

Review of attachment 8573891 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +806,2 @@
>  fi
>  AC_SUBST(NSINSTALL_BIN)

While you're here, you might as well change things in config/config.mk instead (assign NSINSTALL_BIN from NSINSTALL_PY ifndef COMPILE_ENVIRONMENT), and remove this block.
Attachment #8573891 - Flags: review?(mh+mozilla) → feedback+
Is this still an issue? Looks like we can close this bug?
Flags: needinfo?(florian)
(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Is this still an issue? Looks like we can close this bug?

I'm no longer running the Instantbird l10n infra, so I don't expect to encounter this again, even if it's still a bug.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(florian)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.