1140767 - Build more files in security/manager in unified mode

Status: RESOLVED FIXED

(Core :: Security, defect)

Comment 1

[(no longer active)]

Attachment: Build more files in security/manager in unified mode

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8574346 [details] [diff] [review]
Build more files in security/manager in unified mode

I don't know why these files were built in non-unified mode in the first place. Maybe David knows.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8574346 [details] [diff] [review]
Build more files in security/manager in unified mode

Review of attachment 8574346 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: security/manager/ssl/src/moz.build
@@ -67,5 @@
>  ]
>  
>  # nsNSSCertificateDB.cpp needs to include nscert.h before everything else.
> -# The rest cannot be built in unified mode because they want to force NSPR
> -# logging.

Hmmm - looks like this got fixed somewhere along the line (iirc, some files were #defining PR_LOGGING or something that would unconditionally turn on NSPR logging in a way that conflicted with other files - I think PR_LOGGING is defined by default across the tree now, anyway).

Comment 4

[(no longer active)]

Yes indeed.  This became a non-issue a while ago.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98df83a157cb