Closed Bug 1140810 Opened 5 years ago Closed 5 years ago
Upload materially modified records
57 bytes, text/x-github-pull-request
|Details | Review|
This is a TODO in the code right now. We upload status changes (marked as read), new records, and deletions. We don't upload material changes, which means that rows that are populated by a delayed fetch won't end up being reuploaded. This should be mostly copy-and-paste.
Gluten free copy-pasta. I haven't a clue how to make Fennec produce material changes, so this is all based on device JUnit 3 testing.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Attachment #8583467 - Flags: review?(rnewman)
You should be able to cause a material change by simply inserting a SYNCED record with no resolved_url/resolved_title/excerpt and content_status = UNFETCHED while Fennec is running, then wait a brief moment. If Gecko is live, it'll fetch the content and write in those fields. This might require a Robocop test.
Attachment #8583467 - Flags: review?(rnewman) → review+
I intend to uplift the v1 blockers to Aurora all at once.
Comment on attachment 8583467 [details] [review] Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/541 Batch uplift of Android RL to 38.
You need to log in before you can comment on or make changes to this bug.