1140810 - Upload materially modified records

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Reading List Sync, defect)

Description

[Richard Newman [:rnewman]]

This is a TODO in the code right now.

We upload status changes (marked as read), new records, and deletions. We don't upload material changes, which means that rows that are populated by a delayed fetch won't end up being reuploaded.

This should be mostly copy-and-paste.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/541

Gluten free copy-pasta.  I haven't a clue how to make Fennec produce material changes, so this is all based on device JUnit 3 testing.

Comment 2

[Richard Newman [:rnewman]]

You should be able to cause a material change by simply inserting a SYNCED record with no resolved_url/resolved_title/excerpt and content_status = UNFETCHED while Fennec is running, then wait a brief moment. If Gecko is live, it'll fetch the content and write in those fields. This might require a Robocop test.

Comment 3

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/2918aa7b51ca

Comment 4

[Nick Alexander :nalexander [he/him]]

I intend to uplift the v1 blockers to Aurora all at once.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2918aa7b51ca

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8583467 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/541

Batch uplift of Android RL to 38.

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f1c7c471c2d8