Closed Bug 1117830 Opened 5 years ago Closed 5 years ago
Android client for reading list service
This bug tracks work to synchronize reading list data with the service we're building in https://github.com/mozilla-services/readinglist/. Work will include: * FxA OAuth integration. * Frontend settings, perhaps touching the FxA setup wizard. * Implementing the syncing service itself, which is likely to be a SyncAdapter (giving us a checkbox in Settings). Filing in 'Core' until I get a component for this.
WIP is here. I might break this out into more individual bugs if I want to get things landed but keep this open to track deps. https://github.com/mozilla-services/android-sync/pull/527
Leaving this marked as r? for Nick, even though it's still undergoing some polish. We won't pref this on until probably March 20th, when we'll have a final URL, so there's little risk in landing now.
Attachment #8573681 - Flags: review?(nalexander)
Comment on attachment 8573681 [details] [review] Pull req. Oy, what a patch! I can't say I follow the nuances but I think I get the broad strokes. It's just what you pre-flighted (bravo) and just what I expected, modulo a few nits. I would like to see: 1) commenting in all the delegate interface definitions. Understanding "called once" vs. "called many times" is hard without this. 2) fleshing out or removing completely the stubs for "ensure downloaded". Whatever this is intended to be, it's confusing right now. 3) a folding/extraction pass on the GH patch series along functional lines. Evolution is good for in-flight review but not good for understanding functional units in isolation, which is what we'll want 6 months from now. Perhaps: pre/constants/logging, client, storage, synchronizer, adapter integration?
Attachment #8573681 - Flags: review?(nalexander) → review+
Comments addressed in the GitHub branch. I'll fold but won't push, to preserve history. Then I'll merge and land.
Follow-up work for the client is tracked in Bug 1142847.
Needs uplift. Uplift is safe: code turned off.
Whiteboard: [needs uplift]
You need to log in before you can comment on or make changes to this bug.