Closed Bug 1117830 Opened 5 years ago Closed 5 years ago

Android client for reading list service

Categories

(Android Background Services Graveyard :: Reading List Sync, defect)

All
Android
defect
Not set

Tracking

(firefox38 fixed, firefox39 fixed, fennec38+)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
fennec 38+ ---

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

57 bytes, text/x-github-pull-request
nalexander
: review+
Details | Review
This bug tracks work to synchronize reading list data with the service we're building in https://github.com/mozilla-services/readinglist/.

Work will include:

* FxA OAuth integration.
* Frontend settings, perhaps touching the FxA setup wizard.
* Implementing the syncing service itself, which is likely to be a SyncAdapter (giving us a checkbox in Settings).

Filing in 'Core' until I get a component for this.
Depends on: 974664
Depends on: 1117829
Depends on: 1113454
Blocks: 1082011
Blocks: 1123101
No longer depends on: 1113454
Depends on: 1126111
Depends on: 1126139
WIP is here. I might break this out into more individual bugs if I want to get things landed but keep this open to track deps.

https://github.com/mozilla-services/android-sync/pull/527
Depends on: 1127451
See Also: → 1131416
Depends on: 1131421
Depends on: 1130461
Depends on: 1133158
Component: Core → Reading List Sync
Depends on: 1134454
Depends on: 1135900
See Also: → 1136250
Depends on: 1139035
Depends on: 1139946
Depends on: 1140240
Depends on: 1140241
Depends on: 1140243
Attached file Pull req.
Leaving this marked as r? for Nick, even though it's still undergoing some polish.

We won't pref this on until probably March 20th, when we'll have a final URL, so there's little risk in landing now.
Attachment #8573681 - Flags: review?(nalexander)
Blocks: 1140807
Blocks: 1140809
Blocks: 1140810
Blocks: 1140811
Blocks: 1140812
Blocks: 1140813
Blocks: 1141177
Blocks: 1141605
Comment on attachment 8573681 [details] [review]
Pull req.

Oy, what a patch!  I can't say I follow the nuances but I think I get the broad strokes.  It's just what you pre-flighted (bravo) and just what I expected, modulo a few nits.

I would like to see:

1) commenting in all the delegate interface definitions.  Understanding "called once" vs. "called many times" is hard without this.

2) fleshing out or removing completely the stubs for "ensure downloaded".  Whatever this is intended to be, it's confusing right now.

3) a folding/extraction pass on the GH patch series along functional lines.  Evolution is good for in-flight review but not good for understanding functional units in isolation, which is what we'll want 6 months from now.

Perhaps: pre/constants/logging, client, storage, synchronizer, adapter integration?
Attachment #8573681 - Flags: review?(nalexander) → review+
Comments addressed in the GitHub branch.

I'll fold but won't push, to preserve history. Then I'll merge and land.
tracking-fennec: --- → 38+
No longer depends on: 1133158
Blocks: 1142847
No longer depends on: 1127451
No longer depends on: 974664, 1142596, 1142600
Follow-up work for the client is tracked in Bug 1142847.
Needs uplift. Uplift is safe: code turned off.
Flags: needinfo?(rnewman)
Whiteboard: [needs uplift]
Flags: needinfo?(rnewman)
Whiteboard: [needs uplift]
Blocks: 1147164
You need to log in before you can comment on or make changes to this bug.