1117830 - Android client for reading list service

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Reading List Sync, defect)

Description

[Richard Newman [:rnewman]]

This bug tracks work to synchronize reading list data with the service we're building in https://github.com/mozilla-services/readinglist/.

Work will include:

* FxA OAuth integration.
* Frontend settings, perhaps touching the FxA setup wizard.
* Implementing the syncing service itself, which is likely to be a SyncAdapter (giving us a checkbox in Settings).

Filing in 'Core' until I get a component for this.

Comment 1

[Richard Newman [:rnewman]]

WIP is here. I might break this out into more individual bugs if I want to get things landed but keep this open to track deps.

https://github.com/mozilla-services/android-sync/pull/527

Comment 2

[Richard Newman [:rnewman]]

Attachment: Pull req.

Leaving this marked as r? for Nick, even though it's still undergoing some polish.

We won't pref this on until probably March 20th, when we'll have a final URL, so there's little risk in landing now.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8573681 [details] [review]
Pull req.

Oy, what a patch!  I can't say I follow the nuances but I think I get the broad strokes.  It's just what you pre-flighted (bravo) and just what I expected, modulo a few nits.

I would like to see:

1) commenting in all the delegate interface definitions.  Understanding "called once" vs. "called many times" is hard without this.

2) fleshing out or removing completely the stubs for "ensure downloaded".  Whatever this is intended to be, it's confusing right now.

3) a folding/extraction pass on the GH patch series along functional lines.  Evolution is good for in-flight review but not good for understanding functional units in isolation, which is what we'll want 6 months from now.

Perhaps: pre/constants/logging, client, storage, synchronizer, adapter integration?

Comment 4

[Richard Newman [:rnewman]]

Comments addressed in the GitHub branch.

I'll fold but won't push, to preserve history. Then I'll merge and land.

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/d7ace134da7d
https://hg.mozilla.org/integration/fx-team/rev/697d05fddcfc
https://hg.mozilla.org/integration/fx-team/rev/1805b7dc0bcc
https://hg.mozilla.org/integration/fx-team/rev/a57442a57945
https://hg.mozilla.org/integration/fx-team/rev/992c07601414

Comment 6

[Richard Newman [:rnewman]]

Follow-up work for the client is tracked in Bug 1142847.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d7ace134da7d
https://hg.mozilla.org/mozilla-central/rev/697d05fddcfc
https://hg.mozilla.org/mozilla-central/rev/1805b7dc0bcc
https://hg.mozilla.org/mozilla-central/rev/a57442a57945
https://hg.mozilla.org/mozilla-central/rev/992c07601414

Comment 8

[Richard Newman [:rnewman]]

Needs uplift. Uplift is safe: code turned off.

Comment 9

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-aurora/rev/ac253d7f1a15
https://hg.mozilla.org/mozilla-aurora/rev/ac26edd78420
https://hg.mozilla.org/mozilla-aurora/rev/1596a5729a59
https://hg.mozilla.org/mozilla-aurora/rev/8124d4aeea69
https://hg.mozilla.org/mozilla-aurora/rev/b96f11b6c017