1140872 - Service Worker Cache is failing to complete body files in Cache::Put() in trained-to-thrill

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Using the service worker builds, I see now see Cache creating the .tmp files for the images in trained-to-thrill, but it does not complete them to .final files.  If I reload it seems to complete them (and create new .tmp files).

This path is unique in that it uses the CrossProcessPipe, which is not complete.  I suspect that code in bug 1110814 or the CrossProcessPipe itself is failing to close the pipe given to the Cache Manager.  Without the source stream being closed the Manager doesn't know to complete the file write.

I need to work on bug 1110814 first, but I'm filing this so I don't forget about the issue.

Comment 1

[(no longer active)]

Ben, do you still see this?  I can't reproduce...

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #1)
> Ben, do you still see this?  I can't reproduce...

I haven't checked recently.  I want to retest once I have some final patches for bug 1110814.  Lets just leave open as a reminder.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

I don't think this bug is valid any more now that we've switched pipe implementations.  We can re-open or create a new bug if the behavior happens again.