Closed
Bug 1140992
Opened 11 years ago
Closed 11 years ago
[Stingray] [Component] Remove focus and blur function from smart-banner
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: suchiu, Assigned: suchiu)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
In current smart-banner, the focus and blur functions are overrided, which cause unexpected effects.
|
|
Assignee | |
Updated•11 years ago
|
Summary: [Stingray] [Component] Remove focus and blur function in smart-banner → [Stingray] [Component] Remove focus and blur function from smart-banner
|
|
Assignee | |
Comment 2•11 years ago
|
||
1. focus and blur functions are removed.
Attachment #8574568 -
Flags: review?(im)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8574568 [details] [review]
Pull Request
Looks good to me. The original thought of this part is to prevent user to focus or blur the smart banner. Since we have fallback algorithm, this part looks useless and wrong.
Attachment #8574568 -
Flags: review?(im) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Commit: https://github.com/smart-components/smart-banner/commit/e5dda163223d1cc61b0fc5ca0ba140b32eea8150
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•