1141058 - disable Hello in ESR builds

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P2)

Comment 1

[:Gavin Sharp [email: [e-mail]]]

<gavin> Standard8: is disabling for ESR as simple as setting loop.enabled=false?
<Standard8> gavin: yes
<Standard8> well, I hope so! ;-)

Comment 2

[Mike Hoye [:mhoye]]

Shell, are you inclined to mentor this one?

Comment 3

[Mark Banner (:standard8)]

(In reply to Mike Hoye [:mhoye] from comment #2)
> Shell, are you inclined to mentor this one?

This is a one-liner that we're going to need to pull out the bag in a week or so, I don't think its worth mentoring (we've already got more valuable ones in Loop that are mentored).

Comment 4

[Mark Banner (:standard8)]

[Tracking Requested - why for this release]: Updating tracking flags, now that 38esr is available. See previous comments, we want to disable Hello on all the ESR builds.

Comment 5

[Mark Banner (:standard8)]

Attachment: Disable Hello

Simple patch to disable Hello. I ran this on beta and checked the usual tests still pass with this disabled.

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8595330 [details] [diff] [review]
Disable Hello

Review of attachment 8595330 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, quel complexity! ;)

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8595330 [details] [diff] [review]
Disable Hello

Taking it in the esr 38 branch

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr38/rev/f9931c12dc3d

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Hello is successfully disabled in 38.0 ESR, build ID: 20150505103531.

Verified on Windows 7 64-bit, Windows 8.1 32-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit.