1241501 - Disable Hello in ESR 45 builds

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #1141058 +++

Like we did for ESR 38, we should disable Hello in ESR 45 builds. The reason is that we can't supply the type of updates (e.g. TokBox sdk) that we need to continue supporting users which fall outside of the "critical and high security bugs only" requirement.

Comment 1

[Mark Banner (:standard8)]

Attachment: Disable loop on ESR

Simple patch to disable loop via preference. This is the same way as what we did for the previous ESR.

I checked with Mossop and he doesn't see any issues with doing it this way even though we've changed to a system add-on.

Try was happy with it:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=da32f50a62e8

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8723092 [details] [diff] [review]
Disable loop on ESR

Review of attachment 8723092 [details] [diff] [review]:
-----------------------------------------------------------------

Well, hum, honored to be the reviewer of this one!

Comment 3

[Mark Banner (:standard8)]

Sylvestre, this is for ESR 45. The patch is ready when you want it (there's no request flags yet).

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Mark, could you land that into the branch? Thanks

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-esr45/rev/c778b21ceae5a9c9684c0d2c5848412597ba5645
Bug 1241501 - Disable Loop on ESR. r=mikedeboer,a=sledru CLOSED TREE

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Added to the esr 45 release notes