1141353 - Fix ReadingList bookmarks nativemenu on OSX

Status: RESOLVED INCOMPLETE

(Firefox Graveyard :: Reading List, defect, P3)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Bug 1124400 added a submenu in the menubar (under bookmarks) for the ReadingList. Unfortunately, that doesn't work on OSX, which apparently has trouble with dynamically changing menus once they're open. Original plan was to have the storage backend cache the first X items to provide a sync API, but that ended up being shot down.

Options are:
* Keep the menu up to date always. Means (possibly regular) background DOM updates and background DB queries for every window.
* Have a cache per window. Means (possibly regular) background DB queries for every window.
* Have a cache in ReadingList.jsm. Would work same as original fix, but code in a different location. Only one set of DB queries to maintain this cache.

Comment 1

[Justin Dolske [:Dolske]]

What kind of problem, and dynamic how?

Other menus (like History and Recently Closed Tabs) work fine...

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

I'll redirect that to Florian.

Comment 3

[Florian Quèze [:florian]]

(In reply to Justin Dolske [:Dolske] from comment #1)
> What kind of problem, and dynamic how?
> 
> Other menus (like History and Recently Closed Tabs) work fine...

Native Mac menus are only updated when they are opening; the popupshowing event handler is our last opportunity to add content there.

The readinglist code is async, which means the popupshowing handler gets a promise for the list, and we only generate the DOM menuitems when the promise is resolved. This works fine on Windows/Linux, but on Mac the DOM nodes we add after the menu has been shown are never converted to native menu items.

This is an old known issue, see bug 733419.

Comment 4

[Justin Dolske [:Dolske]]

We're ok with shipping as-is (no Reading List item in the native menubar Bookmarks menu), but if we can get the platform fix in time and it's low-risk, it would be great to have. No need for a front-end workaround if not.