1141505 - test_scheduler.js is going to permafail when Gecko 39 merges to Aurora

Status: VERIFIED FIXED

(Firefox Graveyard :: Reading List, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Test permafail when Gecko 39 merges to Aurora.

https://treeherder.mozilla.org/logviewer.html#?job_id=5516279&repo=try

23:41:13 INFO - TEST-START | browser/components/readinglist/test/xpcshell/test_scheduler.js
23:41:14 WARNING - TEST-UNEXPECTED-FAIL | browser/components/readinglist/test/xpcshell/test_scheduler.js | xpcshell return code: 0
23:41:14 INFO - TEST-INFO took 333ms
23:41:14 INFO - >>>>>>>
23:41:14 INFO - PROCESS | 23436 | 1425969674221 readinglist.scheduler INFO readinglist scheduler created.
23:41:14 INFO - PROCESS | 23436 | 1425969674222 readinglist.scheduler INFO scheduler initialzing
23:41:14 INFO - PROCESS | 23436 | 1425969674223 readinglist.scheduler INFO canSync=true
23:41:14 INFO - PROCESS | 23436 | 1425969674224 readinglist.scheduler INFO next scheduled sync is in 19999ms (at Mon Mar 09 2015 23:41:34 GMT-0700 (PDT))
23:41:14 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
23:41:14 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
23:41:14 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
23:41:14 INFO - running event loop
23:41:14 INFO - browser/components/readinglist/test/xpcshell/test_scheduler.js | Starting testSuccess
23:41:14 INFO - (xpcshell/head.js) | test testSuccess pending (2)
23:41:14 INFO - PROCESS | 23436 | *************************
23:41:14 INFO - PROCESS | 23436 | A coding exception was thrown and uncaught in a Task.
23:41:14 INFO - PROCESS | 23436 | Full message: TypeError: allowedOptions.includes is not a function
23:41:14 INFO - PROCESS | 23436 | Full stack: createScheduler@/builds/slave/test/build/tests/xpcshell/tests/browser/components/readinglist/test/xpcshell/test_scheduler.js:33:10
23:41:14 INFO - PROCESS | 23436 | testSuccess@/builds/slave/test/build/tests/xpcshell/tests/browser/components/readinglist/test/xpcshell/test_scheduler.js:88:19
23:41:14 INFO - PROCESS | 23436 | _run_next_test@/builds/slave/test/build/tests/xpcshell/head.js:1376:9
23:41:14 INFO - PROCESS | 23436 | do_execute_soon/<.run@/builds/slave/test/build/tests/xpcshell/head.js:645:9
23:41:14 INFO - PROCESS | 23436 | _do_main@/builds/slave/test/build/tests/xpcshell/head.js:207:5
23:41:14 INFO - PROCESS | 23436 | _execute_test@/builds/slave/test/build/tests/xpcshell/head.js:505:5
23:41:14 INFO - PROCESS | 23436 | @-e:1:1
23:41:14 INFO - PROCESS | 23436 | *************************
23:41:14 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
23:41:14 INFO - Unexpected exception TypeError: allowedOptions.includes is not a function at /builds/slave/test/build/tests/xpcshell/tests/browser/components/readinglist/test/xpcshell/test_scheduler.js:33
23:41:14 INFO - createScheduler@/builds/slave/test/build/tests/xpcshell/tests/browser/components/readinglist/test/xpcshell/test_scheduler.js:33:10
23:41:14 INFO - testSuccess@/builds/slave/test/build/tests/xpcshell/tests/browser/components/readinglist/test/xpcshell/test_scheduler.js:88:19
23:41:14 INFO - _run_next_test@/builds/slave/test/build/tests/xpcshell/head.js:1376:9
23:41:14 INFO - do_execute_soon/<.run@/builds/slave/test/build/tests/xpcshell/head.js:645:9
23:41:14 INFO - _do_main@/builds/slave/test/build/tests/xpcshell/head.js:207:5
23:41:14 INFO - _execute_test@/builds/slave/test/build/tests/xpcshell/head.js:505:5
23:41:14 INFO - @-e:1:1
23:41:14 INFO - exiting test
23:41:14 INFO - PROCESS | 23436 | 1425969674250 readinglist.scheduler DEBUG observed network:offline-status-changed
23:41:14 INFO - PROCESS | 23436 | 1425969674250 readinglist.scheduler INFO canSync=false - we are offline
23:41:14 INFO - <<<<<<<

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0004-Bug-1141505-avoid-array.includes-in-xpcshell-test.-r.patch

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/89cc5bd321ee

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/89cc5bd321ee

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Since this is fixed already I don't think we need to track it.

Ryan, if you still think I need to come back and check up on this, please re-nominate it.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b18bdcfaba79