1141895 - Unprefix values of unicode-bidi

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

According to the MDN page, we have implemented all values of unicode-bidi, but some of them are still prefixed, including: isolate, plaintext, and isolate-override.

The corresponding spec CSS Writing Modes Level 3 has been CR, which means we should be able to safely ship those values unprefixed.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

It seems our current impl of value "isolate" passes all CSSWG tests, while "isolate-override" and "plaintext" still have some problems.

The tests we do not pass includes:
* bidi-isolate-override-005 ~ -010,
* bidi-plaintext-003, -005, -006, -008, -009, -011

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

For whoever interested in testing Firefox with support of unprefixed unicode-bidi values, you can download the builds here: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-71a717058411/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1141895 part 1 - Add unprefixed values for unicode-bidi.

Review commit: https://reviewboard.mozilla.org/r/61486/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61486/

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1141895 part 2 - Use unprefixed unicode-bidi values in internal code.

Review commit: https://reviewboard.mozilla.org/r/61488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61488/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8766680 [details]
Bug 1141895 part 1 - Add unprefixed values for unicode-bidi.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61486/diff/1-2/

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8766681 [details]
Bug 1141895 part 2 - Use unprefixed unicode-bidi values in internal code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61488/diff/1-2/

Comment 7

[Jonathan Kew [:jfkthame]]

Comment on attachment 8766680 [details]
Bug 1141895 part 1 - Add unprefixed values for unicode-bidi.

https://reviewboard.mozilla.org/r/61486/#review58388

Comment 8

[Jonathan Kew [:jfkthame]]

Comment on attachment 8766681 [details]
Bug 1141895 part 2 - Use unprefixed unicode-bidi values in internal code.

https://reviewboard.mozilla.org/r/61488/#review58390

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d4dbb717edd
part 1 - Add unprefixed values for unicode-bidi. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/272f65d9e8d0
part 2 - Use unprefixed unicode-bidi values in internal code. r=jfkthame

Comment 10

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/6d4dbb717edd
https://hg.mozilla.org/mozilla-central/rev/272f65d9e8d0

Comment 11

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/unicode-bidi-values-have-been-unprefixed/

Comment 12

[Jean-Yves Perrier [:teoli]]

Updated:
https://developer.mozilla.org/en-US/docs/Web/CSS/unicode-bidi#Browser_compatibility
and
https://developer.mozilla.org/en-US/Firefox/Releases/50#CSS