Closed Bug 1333675 Opened 6 years ago Closed 6 years ago

Consider removing prefixed value of unicode-bidi

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(2 files)

Bug 1333675 - Remove prefixed values for unicode-bidi.
59 bytes, text/x-review-board-request
dholbert
: review+
Details
followup patch
2.69 KB, patch
Details | Diff | Splinter Review 
Since those values have been unprefixed, we should probably remove the prefixed values.
Summary: Remove prefixed value of unicode-bidi → Consider removing prefixed value of unicode-bidi
These are probably rare enough that we should be able to just go ahead with removing the prefixed versions.
Keywords: site-compat
Comment on attachment 8834745 [details]
Bug 1333675 - Remove prefixed values for unicode-bidi.

https://reviewboard.mozilla.org/r/110588/#review112194

Two commit message nits:
> Remove prefixed value of unicode-bidi. r?dholbert

* s/value/values/
* s/of/for/

...because:
- you're removing multiple values (not just 1)
- these are values *for* the "unicode-bidi" property. ("of" is ambiguous -- and to me, "prefixed value of unicode-bidi" kinda sounds like it'd be referring to "-moz-unicode-bidi")
Attachment #8834745 - Flags: review?(dholbert) → review+
Assignee: nobody → xidorn+moz
Status: NEW → ASSIGNED
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a015f6ca6ac6
Remove prefixed values for unicode-bidi. r=dholbert
Attached patch followup patch — — Splinter Review 

    
    

    
  
philor, could you help landing this patch to autoland?
Flags: needinfo?(philringnalda)

    
    

    
  
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/26a6d86166e7
followup - Remove prefixed values for unicode-bidi from devtools.
Flags: needinfo?(philringnalda)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/a015f6ca6ac6
https://hg.mozilla.org/mozilla-central/rev/26a6d86166e7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago

          status-firefox54:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54

          You need to log in
          before you can comment on or make changes to this bug.