Closed Bug 1141925 Opened 5 years ago Closed 5 years ago

[Hacker Marketplace] Add UI to better support installing Addons

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mikehenrty, Assigned: mikehenrty)

References

()

Details

(Whiteboard: [spark])

Attachments

(1 file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1133976#c6.

This bug aims to fix:
> 4. Add-On Screen: The add-on screen should specify the app/apps it affects
> (see spec page 4, Installing Add-Ons).

Also, addons should not have an Open button.
Attached file [PR] support addons UI
Attachment #8575782 - Flags: review?(dsherk)
Comment on attachment 8575782 [details] [review]
[PR] support addons UI

I left some comments on the PR. None are major, except that before landing this, we should verify with Fabrice that we want to be applying `app.manifest.customizations.filter` to `app.manifestURL`.
Flags: needinfo?(fabrice)
Attachment #8575782 - Flags: review?(dsherk) → review+
Flags: needinfo?(fabrice)
Spoke with fabrice and djf on IRC. Updated the logic to fall more in line with gecko filtering and the settings app.

master: https://github.com/fxos/directory/commit/f06a78b4477de219411c90f5432374d6e0c5e242
Assignee: nobody → mhenretty
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [lightsaber] → [ignite]
Whiteboard: [ignite] → [spark]
You need to log in before you can comment on or make changes to this bug.