Closed Bug 1133976 Opened 5 years ago Closed 5 years ago

[Hacker Marketplace] View a list of available add-ons on Hacker Marketplace

Categories

(Firefox OS Graveyard :: Gaia::Hackerplace, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cserran, Assigned: mikehenrty)

References

()

Details

(Whiteboard: [spark])

User Story

AC1: I want to be able to see both a list of available apps and available addons, separately.

Attachments

(6 files, 2 obsolete files)

No description provided.
No longer depends on: spark-hackerplace
Priority: -- → P1
Blocks: 1133977
No longer blocks: 1133977
Assignee: nobody → mhenretty
Summary: [Hacker Marketplace} View a list of available add-ons on Hacker Marketplace → [Hacker Marketplace] View a list of available add-ons on Hacker Marketplace
User Story: (updated)
Here's the latest spec from Amy.
Attached image [screenhot] app list (obsolete) —
Still working on getting the gaia-buttons component to work. I think I'll have to reach out to Wilson about that. In the meantime, I would like to get a UI review of the other stuff.
Attachment #8573603 - Flags: ui-review?(jsavory)
Attachment #8573603 - Flags: ui-review?(amlee)
Attached image [screenshot] app detail (obsolete) —
Attachment #8573604 - Flags: ui-review?(jsavory)
Attachment #8573604 - Flags: ui-review?(amlee)
Comment on attachment 8573604 [details]
[screenshot] app detail

Hi Michael, is there a way I can review the actual hacker marketplace?

Thanks
(In reply to Amy Lee [:amylee] from comment #4)
> Hi Michael, is there a way I can review the actual hacker marketplace?

If Mike pushes his changes to fxos/directory:master, then you can just update your device using the lightsaber build to view them.
Comment on attachment 8573604 [details]
[screenshot] app detail

Hi Michael, 

Looking good so far. I know the visuals aren't ready for UI review yet so just flag me again when those are ready. For now, here's my feedback:

1. Homescreen: On the homescreen we should use the actual homescreen app icons (i.e camera, dialer) and default to the grey rocket ship icon if none applies (see spec).

2. Homescreen: The font for the tabs “Apps” and “Add-ons” should be Fira Sans Italic. It looks like Light Italic right now.

3. Homescreen: Can you reduce the size of the “upload” icon by 83% ? 

4. Add-On Screen: The add-on screen should specify the app/apps it affects (see spec page 4, Installing Add-Ons).

6. Cancelling Install: When you press install and then hit cancel, it should return to the original screen.  The confirmation screen isn’t needed or the pop-up dialogue box. 

7. App/Add-On screen: When you press install and the install is complete, the button should change to “open”, the same way as when you install from the homescreen. 

8. The app/add-on icons from Hackerplace should match the app/add-on icons on homescreen once the app is installed.

Thanks!
Attachment #8573604 - Flags: ui-review?(amlee) → ui-review-
(In reply to Amy Lee [:amylee] from comment #6)
> 1. Homescreen: On the homescreen we should use the actual homescreen app
> icons (i.e camera, dialer) and default to the grey rocket ship icon if none
> applies (see spec).

Let's not call this homescreen since that could be confused with the gaia homescreen. Let's just call it the List Page or something like that.

In any case, I don't think we should re-use the gaia icons for these apps. These applications are not the same as gaia apps (although the clock one is, but that was just used to test hosted package apps). We can certainly re-use the gaia icons, but I think that would be confusing if the user installed the "Dialer" and then had two apps named "Dialer" on the Gaia homescreen both with the same icon. What do you think?

In any case, there is inconsistency between what's in Hackerplace List Page and what get's displayed on the Gaia Homescreen, and I will fix this.

> 2. Homescreen: The font for the tabs “Apps” and “Add-ons” should be Fira
> Sans Italic. It looks like Light Italic right now.

Ok, I'll check.

> 3. Homescreen: Can you reduce the size of the “upload” icon by 83% ?

Will do.

> 4. Add-On Screen: The add-on screen should specify the app/apps it affects
> (see spec page 4, Installing Add-Ons).

Yeah, I didn't have an add-on I could use just yet, so I have the clock app there, and it doesn't affect any other apps. I'll add a valid add-on to this list and fix this.

> 6. Cancelling Install: When you press install and then hit cancel, it should
> return to the original screen.  The confirmation screen isn’t needed or the
> pop-up dialogue box. 

The confirmation screen we have no control over because it comes from the system app. I will get rid of the pop-up dialog though.

> 7. App/Add-On screen: When you press install and the install is complete,
> the button should change to “open”, the same way as when you install from
> the homescreen.

Yup that's a bug. I'll fix that.

> 8. The app/add-on icons from Hackerplace should match the app/add-on icons
> on homescreen once the app is installed.

Good point, I'll rectify this.
ni? Amy about the question of icons in comment 7.
Flags: needinfo?(amlee)
Depends on: 1140673
Depends on: 1140676
(In reply to Michael Henretty [:mhenretty] from comment #8)
> ni? Amy about the question of icons in comment 7.

Hi Michael, 

If the creator doesn't upload an icon, I would use the default icon (rocketship) for apps/add-ons shown in the spec. Thanks!
Flags: needinfo?(amlee)
Depends on: 1141666
Depends on: 1141925
Depends on: 1142829
Alright, I think this is ready for visual and UX review.
Attachment #8573603 - Attachment is obsolete: true
Attachment #8573604 - Attachment is obsolete: true
Attachment #8573603 - Flags: ui-review?(jsavory)
Attachment #8573603 - Flags: ui-review?(amlee)
Attachment #8573604 - Flags: ui-review?(jsavory)
Attachment #8578860 - Flags: ui-review?(jsavory)
Attachment #8578860 - Flags: ui-review?(amlee)
Hi Michael, 

Here is my feedback for Hackerplace list view (please see attachment for visual reference). I still have to review the app screen so I will post my feedback when I have that ready. Thanks!

List View Feedback
-----------------------

1. The fonts in the tabs still looks like Fira Sans Light. Did you get a chance to check what weight this is? 

2. All dark grey font colours should be #858585 (Headers, Tabs, Creator Name) with the exception of Apps/Add-On List names (#4d4d4d)

3. Font used for App/Add-on name – Check to see if this is Fira Sans Medium.

4. Reference web components for button style. Should be white. http://gaia-components.github.io/gaia-components/

5. Check CSS style for background colour, header colour, and hairline divisions in web components under “settings” http://gaia-components.github.io/gaia-components

6. The default icon should be the following: icon background colour: #DDDDDD, icon colour: #FFFFFF
Comment on attachment 8578860 [details]
[screenshot] available addons

Posted feedback
Attachment #8578860 - Flags: ui-review?(amlee) → ui-review-
Hi Michael 

Here are my edits for the Apps screen. Let me know if you have any questions. I've attached a visual reference to make things clearer 

App Screen Edits
-------------------

App Screen:

1. Default app icon – Icon background colour: #dddddd, Icon colour: #FFFFFF
2. Background/header colour should be #F4F4F4
3. App name/app description/affected apps list font colour: #4D4D4D
4 Header/Affected App Header/Author name/Open button text: #858585
5. Left align all elements – Icon, text, header,
6. When app is already installed, “open” button should change to white with grey text. See web components for styling - http://gaia-components.github.io/gaia-components/
7. Can’t scroll down to view whole list affected apps list - Bug?
8. Error message dialogue box - When installing the sharing app I get a "Install Error: No network" pop-up when I don't have a connection. The text looks a bit big, please reference the web components style under Dialogue -> Alert http://gaia-components.github.io/gaia-components/

Thanks!
Attachment #8580207 - Flags: review?(drs) → review+
Comment on attachment 8580207 [details] [review]
[PR] updates based on feedback

master: https://github.com/fxos/directory/commit/94f90653b16186aea039cbf0c1fbc0e95fa35b2b

Amy let's do another review.
Attachment #8580207 - Flags: ui-review?(amlee)
Comment on attachment 8580207 [details] [review]
[PR] updates based on feedback

There is a light blue outline around the white on-press state of the install button as if the blue install button is underneath. + this review with the assumption it will be fixed in the web components. Thanks Michael!
Attachment #8580207 - Flags: ui-review?(amlee) → ui-review+
Attachment #8580207 - Flags: ui-review?(jsavory)
Attached image 2015-03-23-16-40-53.png
Hairline is missing from the top tab menu. Colour should be #e7e7e7 (see attached). Thanks!
(In reply to Amy Lee [:amylee] from comment #17)
> Created attachment 8581916 [details]
> 2015-03-23-16-40-53.png
> 
> Hairline is missing from the top tab menu. Colour should be #e7e7e7 (see
> attached). Thanks!

I'll fix that in bug 1133979. Let's close this bug for now, and do the final reviews in that bug.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8580207 [details] [review]
[PR] updates based on feedback

We'll have Jacqueline do the final review in bug 1133979.
Attachment #8580207 - Flags: ui-review?(jsavory)
Whiteboard: [lightsaber] → [spark]
Component: Gaia → Gaia::Hackerplace
You need to log in before you can comment on or make changes to this bug.