1142015 - Implement serviceWorker.postMessage API spec changes

Status: RESOLVED FIXED

Description

[Cătălin Badea (:catalinb)]

http://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-postmessage

MessageEvents should have a source object.
MessageEvent should contain an array of message ports.

Comment 1

[Cătălin Badea (:catalinb)]

Created attachment 8575951 [details] [diff] [review]
Add source for messages dispatched to a Service Worker.

Comment 2

[Cătălin Badea (:catalinb)]

The webidl change for MessageEvent is being tracked here: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28199.

Comment 3

[Andrea Marchesini [baku - back the 24th of August]]

Comment on attachment 8575951 [details] [diff] [review]
Add source for messages dispatched to a Service Worker.

Review of attachment 8575951 [details] [diff] [review]:
-----------------------------------------------------------------

Just 1 thing: SetSource(workers::ServiceWorker* aServiceWorker); is not actually used. Remove it and file a follow-up for that.

::: dom/events/MessageEvent.h
@@ +17,5 @@
>  struct MessageEventInit;
>  class MessagePort;
>  class MessagePortBase;
>  class MessagePortList;
> +class OwningWindowProxyOrMessagePortOrServiceWorkerOrClient;

remove this.

@@ +19,5 @@
>  class MessagePortBase;
>  class MessagePortList;
> +class OwningWindowProxyOrMessagePortOrServiceWorkerOrClient;
> +
> +typedef OwningWindowProxyOrMessagePortOrServiceWorkerOrClient MessageEventSource;

we don't need this, right?

@@ +68,5 @@
>  
>    // Non WebIDL methods
>    void SetSource(mozilla::dom::MessagePort* aPort);
>  
> +  void SetSource(workers::ServiceWorker* aServiceWorker);

You don't actually use this.

::: dom/webidl/MessageEvent.webidl
@@ +6,5 @@
>   * For more information on this interface, please see
>   * http://www.whatwg.org/specs/web-apps/current-work/#messageevent
>   */
>  
> +typedef (WindowProxy or MessagePort or ServiceWorker or Client) MessageEventSource;

I don't think this change is part of http://www.whatwg.org/specs/web-apps/current-work/#messageevent
Add the URL of the  new spec at line 7.

::: dom/workers/WorkerPrivate.cpp
@@ +3103,5 @@
>  void
>  WorkerPrivateParent<Derived>::PostMessageInternal(
>                                              JSContext* aCx,
>                                              JS::Handle<JS::Value> aMessage,
>                                              const Optional<Sequence<JS::Value> >& aTransferable,

can you fix the indentation of this method?

Comment 4

[Cătălin Badea (:catalinb)]

Created attachment 8578167 [details] [diff] [review]
Add source for messages dispatched to a Service Worker.

Comment 5

[Cătălin Badea (:catalinb)]

Created attachment 8578207 [details] [diff] [review]
Add source for messages dispatched to a Service Worker.

Comment 6

[Cătălin Badea (:catalinb)]

Comment on attachment 8578207 [details] [diff] [review]
Add source for messages dispatched to a Service Worker.

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=dbdd76cde1de

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dbdd76cde1de