1142114 - Many devtools test failures with current SDK code

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Dave Townsend [:mossop]]

A bunch of failures here because of a redeclared variable.

Comment 1

[Dave Townsend [:mossop]]

Attachment: pull request

Comment 2

[Dave Townsend [:mossop]]

Attachment: devtools patch

Some of this devtools test is broken, calling once with no listener and assuming it returns a promise.

Comment 3

[Dave Townsend [:mossop]]

Devtools fixes: https://hg.mozilla.org/integration/fx-team/rev/e5ea062a8a10

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/9e9fbeaa0c491cbfa1f84c9b2dcaf00c4cce4aca
Bug 1142114: Rename loader to loaderModule to avoid conflicts with the devtools loader.

https://github.com/mozilla/addon-sdk/commit/1fec9081349b390384e2f710a8582e61fef8ae54
Merge pull request #1890 from Mossop/bug1142114

Bug 1142114: Rename loader to loaderModule to avoid conflicts with the devtools loader. r=erikvold

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for bc1 orange: 
https://treeherder.mozilla.org/logviewer.html#?job_id=2238309&repo=fx-team
https://hg.mozilla.org/integration/fx-team/rev/a72fa2612001

Comment 6

[Dave Townsend [:mossop]]

Relanded as a try run suggests this wasn't at fault.

https://hg.mozilla.org/integration/fx-team/rev/a79fada9fcbf

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a79fada9fcbf