Closed Bug 1142114 Opened 8 years ago Closed 8 years ago

Many devtools test failures with current SDK code

Categories

(Add-on SDK Graveyard :: General, defect, P1)

defect

Tracking

(firefox39 fixed)

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(2 files)

A bunch of failures here because of a redeclared variable.
Blocks: 1137930, 1130529
Attached file pull request
Attachment #8576150 - Flags: review?(evold)
Attached patch devtools patchSplinter Review
Some of this devtools test is broken, calling once with no listener and assuming it returns a promise.
Attachment #8576154 - Flags: review?(jsantell)
Attachment #8576154 - Flags: review?(jsantell) → review+
Attachment #8576150 - Flags: review?(evold) → review+
Priority: -- → P1
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/9e9fbeaa0c491cbfa1f84c9b2dcaf00c4cce4aca
Bug 1142114: Rename loader to loaderModule to avoid conflicts with the devtools loader.

https://github.com/mozilla/addon-sdk/commit/1fec9081349b390384e2f710a8582e61fef8ae54
Merge pull request #1890 from Mossop/bug1142114

Bug 1142114: Rename loader to loaderModule to avoid conflicts with the devtools loader. r=erikvold
Relanded as a try run suggests this wasn't at fault.

https://hg.mozilla.org/integration/fx-team/rev/a79fada9fcbf
Flags: needinfo?(dtownsend)
https://hg.mozilla.org/mozilla-central/rev/a79fada9fcbf
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.